Vote #77947
完了htmlentities warning
0%
説明
During my migration to 3.3.1, I got this warning:
.../ruby/gems/2.3.0/gems/htmlentities-4.3.1/lib/htmlentities/mappings/expanded.rb:465: warning: key "inodot" is duplicated and overwritten on line 466
Installing htmlentities 4.3.4 seems to resolve this message. Have not had any issues with htmlentities yet.
journals
It cause by this.
https://github.com/naitoh/rbpdf/issues/33
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
This problem fixed by rbpdf 1.19.1.
please bundle update.
--------------------------------------------------------------------------------
Jun NAITOH wrote:
> This problem fixed by rbpdf 1.19.1.
> please bundle update.
I confirmed that this issue can be fixed by executing @bundle update@.
Naitoh-san, thank you for maintaining rbpdf.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
An error occurs when running bundle update with rbpdf 1.19.1 under windows:
<pre>
Using rbpdf-font 1.19.1
Encoding::UndefinedConversionError: "\x81" to UTF-8 in conversion from Windows-1
252 to UTF-8
An error occurred while installing rbpdf (1.19.1), and Bundler cannot continue.
Make sure that `gem install rbpdf -v '1.19.1'` succeeds before bundling.
</pre>
--------------------------------------------------------------------------------
3.2.6 release is planned for this week-end, I'll have to revert to previous rbpdf version unless a fixed version of rbpdf is released. Thanks.
--------------------------------------------------------------------------------
What Ruby version do you use?
I cannot reproduce on ruby 2.2.6p396 (2016-11-15 revision 56800) [i386-mingw32] in Japanese Windows 10.
--------------------------------------------------------------------------------
I can confirm rbpdf 1.19.1 cannot be installed on Ruby 1.9.3 and 2.0 on Windows.
I think there is no benefit to continue support Ruby 1.9.3 and 2.0.
So I create #25538.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Toshi's test shows that the problem reported by Jean-Phillipe (#24271#note-6) occurs only with older versions of Ruby.
I think that it would be better to pin rbpdf version for Ruby <=2.0 only. Many Redmine user in Japan are annoyed with the defect #22335 due to rbpdf 1.19.0.
<pre><code class="diff">
Index: Gemfile
===================================================================
--- Gemfile (revision 16517)
+++ Gemfile (working copy)
@@ -24,7 +24,7 @@
# Windows does not include zoneinfo files, so bundle the tzinfo-data gem
gem 'tzinfo-data', platforms: [:mingw, :x64_mingw, :mswin]
-gem "rbpdf", "1.19.0"
+gem "rbpdf", (RUBY_VERSION >= "2.1" ? "~> 1.19.1" : "1.19.0")
# Optional gem for LDAP authentication
group :ldap do
</code></pre>
--------------------------------------------------------------------------------
I want to prevent old Ruby user will say "ChangeLog says htmlentities warning fixed, but my Redmine still warn on my Redmine why?".
--------------------------------------------------------------------------------
Jean-Philippe Lang wrote:
> An error occurs when running bundle update with rbpdf 1.19.1 under windows:
Sorry, I will fix today, this problem.
> 3.2.6 release is planned for this week-end, I'll have to revert to previous rbpdf version unless a fixed version of rbpdf is released. Thanks.
Please wait.
--------------------------------------------------------------------------------
Toshi MARUYAMA wrote:
> I want to prevent old Ruby user will say "ChangeLog says htmlentities warning fixed, but my Redmine still warn on my Redmine why?".
How about updating Gemfile as I wrote in #24271#note-12 without closing this issue (without listing this issue in CHANGELOG)? We can list this issue after dropping support for older versions of Ruby. I think that it is beneficial for users to deliver deliver fixes as soon as possible.
As Holger Just wrote in #25538#note-7, I think dropping Ruby 2.0 support right now is somewhat problematic.
--------------------------------------------------------------------------------
Jun NAITOH wrote:
> Jean-Philippe Lang wrote:
> > An error occurs when running bundle update with rbpdf 1.19.1 under windows:
>
> Sorry, I will fix today, this problem.
>
> > 3.2.6 release is planned for this week-end, I'll have to revert to previous rbpdf version unless a fixed version of rbpdf is released. Thanks.
>
> Please wait.
This problem fixed by rbpdf 1.19.2.
please bundle update.
--------------------------------------------------------------------------------
Jun NAITOH wrote:
> This problem fixed by rbpdf 1.19.2.
> please bundle update.
Great! Thank you for fixing this.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
duplicates,Closed,24917,duplicated key upgrading from 3.3.1 to 3.3.2 version