Vote #77966: Allow Journal to return empty Array instead nil in Journal#attachments - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #77966

完了

Allow Journal to return empty Array instead nil in Journal#attachments

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

Attachments_19

対象バージョン:

3.4.0_119

開始日:

2022/05/09

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/24308

category_id:

version_id:

119

issue_org_id:

24308

author_id:

161955

assigned_to_id:

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

If we journalize objects without @#attachments@ then take exception (@TypeError: no implicit conversion of nil into Array@) in @app/helpers/application_helper.rb@


  def parse_inline_attachments(text, project, obj, attr, only_path, options)
    ...
    attachments += obj.attachments if obj.respond_to?(:attachments)
    ...
  end

journals

--------------------------------------------------------------------------------
Patch committed, thanks.
--------------------------------------------------------------------------------