Another patches for overview, activity and roadmap tabs.
--------------------------------------------------------------------------------
Added the last patches:

h3. - 05_use_regular_icons_in_search_results.patch:

The change from the view (app/views/search/index.html) was required because the classes in the search page are delimited by space and not by "-" like in the activity page even if are the same events. I think that this fix should be made in the Search and libs modules in order to return the same event_type for closed issues, but I wasn't able to do it.

event type: closed issue
class in activity: "issue-closed"
class in search: "issue closed"

h3. - 06_other_pages.patch

Changes in various pages: like favorite projects, members, attachments, forums.

h3. - 07_small_improvement.patch:

The class "icon" should not have the rules with padding-top and padding-bottom because these are required only when the font size is smaller than the default one (like is in the contextual block or calendar).

h3. - Updated an already uploaded patch to use the background-image rule and not just the background rule.

h3. - There are some rules in the CSS file that I wasn't able to find them in the application:

<pre>
table.boards a.board { background: url(../images/comment.png) no-repeat 0% 50%; padding-left: 20px; }
</pre>

<pre>
span.add_attachment a {padding-left:16px; background: url(../images/bullet_add.png) no-repeat 0 50%; }
</pre>

<pre>
.task_late { background:#f66 url(../images/task_late.png); border: 1px solid #f66; }
.task_done { background:#00c600 url(../images/task_done.png); border: 1px solid #00c600; }
.task_todo { background:#aaa url(../images/task_todo.png); border: 1px solid #aaa; }
...
.project.task_late { background:#f66 url(../images/milestone_late.png); border: 1px solid #f66; height: 2px; margin-top: 3px;}
.project.task_done { background:#00c600 url(../images/milestone_done.png); border: 1px solid #00c600; height: 2px; margin-top: 3px;}
.project.task_todo { background:#fff url(../images/milestone_todo.png); border: 1px solid #fff; height: 2px; margin-top: 3px;}
.project.marker { background-image:url(../images/project_marker.png); background-repeat: no-repeat; border: 0; margin-left: -4px; margin-top: 1px; }
</pre>

Any feedback is welcome on this issue.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Activity view: event type class preserved in addition to the icon-* class.
--------------------------------------------------------------------------------
Jean-Philippe Lang wrote:
> Activity view: event type class preserved in addition to the icon-* class.

I've updated the patch *05_use_regular_icons_in_search_results.patch* in order to preserve the event type class like you made in the activity.

Thanks for committing this patch so fast.
--------------------------------------------------------------------------------
Marius BALTEANU wrote:

> h3. - 05_use_regular_icons_in_search_results.patch:
>
> The change from the view (app/views/search/index.html) was required because the classes in the search page are delimited by space and not by "-" like in the activity page even if are the same events. I think that this fix should be made in the Search and libs modules in order to return the same event_type for closed issues, but I wasn't able to do it.

There was a difference between Issue and Journal acts_as_event definition. It's fixed and I've removed the #parameterize call from the patch.
--------------------------------------------------------------------------------
Patch 6 committed with several changes. I've added a few @icon-*@ (eg. @icon-sticky@) classes that are more meaningful than @icon-arrow-right@, even if they actually use the same image in the default CSS.
--------------------------------------------------------------------------------
And I've hidden the user icon on the member list, just like it was before the patches.

All patches are now committed, thanks.
--------------------------------------------------------------------------------
Thanks Jean-Philippe Lang for your feedback on these patches.

I think that one more change is required, you committed the *02_use_regular_icons_in_overview_tab.patch* and not the second version of the patch *02_use_regular_icons_in_overview_tab_v2.patch* which contains a small fix for .icon-new class.
<pre>
.icon-news { background: url(../images/news.png); }
</pre>
should be
<pre>
.icon-news { background-image: url(../images/news.png); }
</pre>
--------------------------------------------------------------------------------
Marius BALTEANU wrote:

> I think that one more change is required

Committed, thanks.

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

relates,Closed,28605,Add the missing icon class to the items with icons from the contextual menu
relates,Closed,31433,Use "icon icon-*" classes for sort-handler, collapsible fieldsets and collapsible versions