Vote #77999
未完了Progress of version should be calculated the same way as parent tasks
0%
説明
The progress of a version should be calculated the same ways as the progress of parent tasks are calculated in #23511.
journals
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
The progress for version is not calculated correctly.
It only uses the estimated time for issues in the version so if mixing issues with an estimated time >0.0h and issues without an estimated time then the issues without an estimated time is not contributing to the progress at all.
It should also use the total_estimated_time instead of just estimated_time, this will make the progress correct if the parent is in the version but not the children.
I've attached a fix that shows what I had in mind.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Could you add tests?
source:trunk/test/unit/version_test.rb@15993#L80
--------------------------------------------------------------------------------
I'll see if I can squeeze in some time for this in the near future.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
I've updated the patch posted by C-O-L and added to it a test posted by Etienne some years ago to #4682. I can confirm that this patch fixes the related issue (#4682), but I'm not sure about the defect reported here.
From my point of view, we should take into account the total estimated hours (as the patch proposes), but I'm not sure that issues estimated at 0 hours should be treated in the same way as the issues without estimated hours.
Also, the patch generates quite a lot of queries.
I'm assigning this to version:"4.1.0" to clarify at least the expected behaviour. I think it could be an important fix.
--------------------------------------------------------------------------------
related_issues
relates,Closed,23511,Progress of parent task should be calculated using total estimated hours of children
relates,Confirmed,4682,Completed version with wrong progress bar status