プロジェクト

全般

プロフィール

Vote #78091

未完了

[regression?] r10132's changes were reverted with r15569

Admin Redmine さんが約4年前に追加. 約4年前に更新.

ステータス:
Confirmed
優先度:
通常
担当者:
-
カテゴリ:
Third-party libraries_47
対象バージョン:
-
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
47
version_id:
0
issue_org_id:
24723
author_id:
1565
assigned_to_id:
1565
comments:
3
status_id:
9
tracker_id:
1
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Confirmed]

説明

The adjustments made in r10132 were reverted by r15569 for #23107. Was this intentional, eg. to bring the upstream alpha base in sync with Redmine's theme or was it by mistake? Either way, the inline styles in the multilingual wiki_syntax_detailed_[*].html documentation needs to be re-synced again (like in r14492 for #20288). Before I start mocking-up a patch, I'd like to know what was/is intended...


journals

I guess they were not reverted intentionally.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
I am working on this. I'll leave an incomplete WIP patch that just re-introduces the changes from r10132 as I don't have time to complete this task today. I'll continue working on it tomorrow.
Still to do:
* check upstream modifications of styles adjusted by/after r10132:
** _lib/coderay/styles/alpha.rb:_
*** https://github.com/rubychan/coderay/compare/v1.0.9...v1.1.0#diff-e5baede8c0d3580f160114fce2f07083
*** https://github.com/rubychan/coderay/compare/v1.1.0...v1.1.1#diff-e5baede8c0d3580f160114fce2f07083
* make sure the styles used for documentation files are in sync with Redmine's CodeRay styles with the final changes for this issue applied (made easier by #24800).
* compare all changes with #24681, review them and report back.

This patch, against current source:/trunk@16171, is produced using git format-patch which makes the patch apply-able using "@patch -p1 < 0001-...@".

--------------------------------------------------------------------------------


related_issues

relates,Closed,24800,Remove internal style sheet duplication and obsoleted meta tag from wiki_syntax_* documentation.

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0