Vote #78110
完了UI inconsistencies on /enumerations/index view
0%
説明
Coming out of and a follow-up to #24720. I spotted three things that could benefit improvement:
- re-position the new enumeration links to above the item tables (in line with #24720 changes)
- add 'icon' and 'icon-add' classes to the new enumeration links (like most, if not all, new ... links in both the front- and the back-end) to make them stand-out more
- handle cases of none existing enumerations using the regular @no-data@ message blocks
I attach three patches implementing these changes. This patch serial, against current source:/trunk@16156, is produced using git format-patch which makes the individual patches apply-able using "@patch -p1 < 0001-...@".
journals
Some comparative screenshots.
Before:
!before.png!
After:
!after.png!
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Nice improvement.
But I think it would be better to set more margin between the table and the next heading. Please see the following screenshots.
*current patch:*
!before-add-margin.png!
*set more margin:*
!after-add-margin.png!
--------------------------------------------------------------------------------
Go MAEDA wrote:
> But I think it would be better to set more margin between the table and the next heading. Please see the following screenshots.
I totally agree. Thanks for reviewing and your feedback. I'll leave an updated, rebased patch set — against source:/trunk@16171 — adding a fourth patch containing the CSS rule you've proposed. The first three patches didn't change by content, only its metadata.
Regarding the CSS rule: while it fixes practical all cases[1], it does leave a difference between the space between the tables and the following headers ánd the space between the paragraphs and the following headers. See the following two screenshots:
* Remaining difference made visual:
!rare-case-indifferent-distance.png!
* Extreme case without any enumerations at all:
!extreme-case.png!
This cannot be fixed easily (and in a clean way) due to the current structure of the page. Though, given the rarity of the case, I think I can live with this minor drawback/trade-off. But, YMMV...
fn1. I've almost never seen Redmine instances in production without enumerations, only just installed ones where no default data was loaded yet.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Mischa The Evil wrote:
> Regarding the CSS rule: while it fixes practical all cases[1], it does leave a difference between the space between the tables and the following headers ánd the space between the paragraphs and the following headers. See the following two screenshots:
Looks good to me. Thanks!
I think this issue is now ready to be merged. Setting target version to 3.4.0.
> fn1. I've almost never seen Redmine instances in production without enumerations, only just installed ones where no default data was loaded yet.
Absolutely agree.
--------------------------------------------------------------------------------
Patch committed, thanks Mischa.
--------------------------------------------------------------------------------
related_issues
relates,Closed,24720,Move all 'new item' links in project settings to above the item tables