Vote #78184: Render high resolution Gravatars and Thumbnails - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #78184

完了

Render high resolution Gravatars and Thumbnails

Admin Redmine さんが4年以上前に追加. 4年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

UI_10

対象バージョン:

3.4.0_119

開始日:

2022/05/09

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/24927

category_id:

version_id:

119

issue_org_id:

24927

author_id:

347

assigned_to_id:

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

In addition to #24922, this patch implements hi-res support for Gravatars and Thumbnails using the @srcset@ attribute. Only a DPR of 2x is supported currently.

Here, the patch will actually use separate URLs for 1x and 2x images, so that browsers supporting @srcset@ will only load the appropriate image and will not need to scale on the client.

journals

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Quick fix.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Thanks for the patch. Gravatar icons and thumbnails for HDPI display is beautiful.
But I see strange blank area in Firefox. Could you inspect it?

!24927-thumbnail-problem-in-firefox.png!
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Thanks for pointing this out. I'm adding two more patches which fix this problem. To me it looks like a bug in Firefox, though...
--------------------------------------------------------------------------------
Jan from Planio www.plan.io wrote:
> Thanks for pointing this out. I'm adding two more patches which fix this problem.

Thanks, I confirmed that the problem has been fixed.

--------------------------------------------------------------------------------
With these patches, we can see sharp Gravatar icons and thumbnails on High DPI monitors.
High DPI monitors are becoming common these days, so I think that this feature should be included in 3.4.0.

!24927-effect-gravatar.png!
--------------------------------------------------------------------------------
Committed, thanks.
--------------------------------------------------------------------------------

related_issues

relates,Closed,24922,Support high resolution images in formatted content
relates,New,11757,Add support for HDPI screens (retina)
blocks,Closed,24935,Gravatar icons in activity view are broken on r15858 and later