--------------------------------------------------------------------------------
uk?
Why not ua?…
--------------------------------------------------------------------------------
VVD VVD wrote:
> uk?
> Why not ua?…

I think 'uk' is right ISO 639-1 code for Ukrainian language.

https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes
https://www.loc.gov/standards/iso639-2/php/code_list.php
--------------------------------------------------------------------------------
See "this":https://github.com/svenfuchs/rails-i18n/issues/285 issue on rails-i18n which explains @uk@ vs. @ua@ pretty well and see the leading "IANA Language Subtag Registry":http://www.iana.org/assignments/language-subtag-registry/language-subtag-registry. As such, @uk@ is fine and in line with Rails core.

@Anton Oslyak: can you provide a patch[1] against current trunk for this? That would make the life of the committer much prettier.. And can you also translate:
* the wiki toolbar language file: source:/trunk/public/javascripts/jstoolbar/lang/jstoolbar-uk.js
* the bundled help files: source:/trunk/public/help/uk

Ref.: [[HowTo_translate_Redmine_in_your_own_language]].

Thanks for your contribution.

fn1. see [[patch]] and [[How_to_create_patch_series_on_Mercurial_and_Git]] for instructions
--------------------------------------------------------------------------------
Done!

URL: https://svn.redmine.org/redmine/trunk
revision: 16333

Translated files:

<pre>
./config/locales/uk.yml
./public/javascripts/jstoolbar/lang/jstoolbar-uk.js
./public/help/uk/wiki_syntax_markdown.html
./public/help/uk/wiki_syntax_textile.html
./public/help/uk/wiki_syntax_detailed_textile.html
./public/help/uk/wiki_syntax_detailed_markdown.html
</pre>
--------------------------------------------------------------------------------
Btw,
Inside Ukraine everywhere:

* national domain *.ua*
* at car number plates,
* at the documents,
* even in currency sign UAH (Ukrainian hryvnia)

Used UA symbols, not UK

But in my international passport.
<pre>
Country code: UKR
</pre>

Even Google translator "translate UK":https://translate.google.com/?prev=_t&hl=ru&ie=UTF-8&eotf=1&text=&sl=en&tl=ru#en/uk/UK from English to Ukrainian as Great Britain

So, I think that correct variant is for two chars UA and for three chars UKR

P.S. But I don't think it has really matter.

--------------------------------------------------------------------------------
Anton Oslyak wrote:
> Done!
>
> URL: https://svn.redmine.org/redmine/trunk
> revision: 16333

It seems something went wrong as your patch is reverting r16206, r16207 and r16208. Probably it is not made against current trunk. Can you please fix this?

Anton Oslyak wrote:
> Btw,
> Inside Ukraine everywhere:
>
> * national domain *.ua*
> * at car number plates,
> * at the documents,
> * even in currency sign UAH (Ukrainian hryvnia)
>
> Used UA symbols, not UK
>
> But in my international passport.
> [Country code: UKR]
>
> Even Google translator "translate UK":https://translate.google.com/?prev=_t&hl=ru&ie=UTF-8&eotf=1&text=&sl=en&tl=ru#en/uk/UK from English to Ukrainian as Great Britain
>
> So, I think that correct variant is for two chars UA and for three chars UKR
>
> P.S. But I don't think it has really matter.

Well, the international passport seems to use ISO 639-2 for the country code. @UA@ is the official ISO 3166-1 _country_ code whereas @uk@ is the official ISO 639-1 _language_ code.

--------------------------------------------------------------------------------
Let's break it's in a few steps

First of all I fixed all files exept uk.yml

Please check it
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Anton Oslyak wrote:
> * *File* ukrainian_localization_without_uk_yml.diff added
> * *File* ukrainian_localization_without_uk_yml.patch added
>
> First of all I fixed all files exept uk.yml
>
> Please check it

Done, both (they are actually equal besides the extension) apply cleanly onto current trunk @ r16333. I haven't done (and am unable to do) any substantial review of these patches as I'm not a speaker of the respective language, but they 'structurally' look good.
--------------------------------------------------------------------------------
Yes, files was identical besides the extension

Why when

<pre>
svn co https://svn.redmine.org/redmine/trunk
</pre>

I don't see my changes???

And last changes in repository
<pre>
2017-02-12 16:09:07 +0200
</pre>

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Committed in trunk r16410, thanks.
--------------------------------------------------------------------------------