Vote #78252
完了ThemesTest#test_without_theme_js may fail if third-party theme is installed
開始日:
2022/05/09
期日:
進捗率:
0%
予定工数:
Redmineorg_URL:
category_id:
38
version_id:
119
issue_org_id:
25118
author_id:
332
assigned_to_id:
1
comments:
3
status_id:
5
tracker_id:
1
plus1:
0
affected_version:
closed_on:
affected_version_id:
説明
test/unit/lib/redmine/themes_test.rb may fail if third party theme which has javascripts/theme.js is installed.
1) Failure: ThemesTest#test_without_theme_js [test//integration/lib/redmine/themes_test.rb:43]: Expected exactly 0 elements matching "script[src^="/themes/redminecrm/javascripts/theme.js"]", found 1.. Expected: 0 Actual: 1
This issue can be fixed by the following patch:
Index: test/integration/lib/redmine/themes_test.rb
===================================================================
--- test/integration/lib/redmine/themes_test.rb (revision 16332)
+++ test/integration/lib/redmine/themes_test.rb (working copy)
@@ -37,6 +37,8 @@
end
def test_without_theme_js
+ # simulate a state theme.js does not exists
+ @theme.javascripts.clear
get '/'
assert_response :success
journals
--------------------------------------------------------------------------------
Committed, thanks.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
relates,Closed,31941,ThemesTest may fail if a third-party theme with a favicon is installed
いいね!0