プロジェクト

全般

プロフィール

Vote #78327

完了

Git 2.9 compatibility

Admin Redmine さんが約4年前に追加. 約4年前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
SCM_3
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
3
version_id:
126
issue_org_id:
25371
author_id:
162465
assigned_to_id:
0
comments:
6
status_id:
5
tracker_id:
1
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

With git 2.9 I have some problems with redmine git tests.

Failure:
RepositoryGitTest#test_fetch_changesets_from_scratch [redmine/trunk/test/unit/repository_git_test.rb:139]:
Expected: 39
Actual: 38

This patch heals it.


journals

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Fixed in trunk, 3.3-stable, and 3.2-stable.
Thanks for pointing out.
--------------------------------------------------------------------------------
Thank you!
Sorry for reopening (I think, there is no need for new issue), but I have problems with tests (with git 2.9) again.

Failure:
RepositoriesGitControllerTest#test_diff_should_show_filenames [/trunk/test/functional/repositories_git_controller_test.rb:380]:
<test.txt> expected but was
<copied_README>..
Expected 0 to be >= 1.

It seems, that the cure is the same

--- lib/redmine/scm/adapters/git_adapter.rb (revision 16427)
+++ lib/redmine/scm/adapters/git_adapter.rb (working copy)
@@ -317,6 +317,7 @@
cmd_args << '--no-renames' if self.class.client_version_above?([2, 9])
else
cmd_args << "show" << "--no-color" << identifier_from
+ cmd_args << '--no-renames' if self.class.client_version_above?([2, 9])
end
cmd_args << "--" << scm_iconv(@path_encoding, 'UTF-8', path) unless path.empty?
diff = []

--------------------------------------------------------------------------------
Fixed. Thanks for pointing out.
--------------------------------------------------------------------------------

Admin Redmine さんが約4年前に更新

  • カテゴリSCM_3 にセット
  • 対象バージョン3.2.6_126 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0