Vote #78483
完了View repository content by default (instead of the history)
0%
説明
In line with the changes proposed in #25988, I'd like to propose to change the default behaviour for clicking on entries in the repository to showing the entry's contents, rather than it's history. The research we did at "Planio":https://plan.io showed that viewing is the more common action. GitHub and Bitbucket use the same behaviour, by the way.
This patch series also introduces the existing 2nd level tab style for the "View", "History", and "Annotate" links on repo entries and adds the download icon introduced in #25988 to the download links to make them a little more prominent.
Here's a screenshot:
!{width:500px}repo_entries_tabs.png!
journals
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Jan from Planio www.plan.io wrote:
> I'd like to propose to change the default behaviour for clicking on entries in the repository to showing the entry's contents, rather than it's history. The research we did at "Planio":https://plan.io showed that viewing is the more common action.
Absolutely agree. To be honest, it was frustrating for me to click a lot to see source codes. I am sure that the patch can greatly improves UX of Redmine.
--------------------------------------------------------------------------------
I think it would be even better to change link destination of the breadcrumbs too.
<pre><code class="diff">
diff --git a/app/views/repositories/_breadcrumbs.html.erb b/app/views/repositories/_breadcrumbs.html.erb
index eb115f9ad..82f25d43a 100644
--- a/app/views/repositories/_breadcrumbs.html.erb
+++ b/app/views/repositories/_breadcrumbs.html.erb
@@ -18,7 +18,7 @@ dirs.each do |dir|
<% end %>
<% if filename %>
/ <%= link_to filename,
- :action => 'changes', :id => @project, :repository_id => @repository.identifier_param,
+ :action => 'entry', :id => @project, :repository_id => @repository.identifier_param,
:path => to_path_param("#{link_path}/#{filename}"), :rev => @rev %>
<% end %>
<%
</code></pre>
!{width: 550px;}.repo-browser-breadcrumbs@2x.png!
--------------------------------------------------------------------------------
+1 Nice improvement.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
This is a great improvement. Setting target version to 3.4.0.
--------------------------------------------------------------------------------
Go MAEDA wrote:
> I think it would be even better to change link destination of the breadcrumbs too.
Thank you for improving my patch! I totally agree.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Please find attached updated patch 0001. It now contains the changes suggested by Go.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Jan from Planio www.plan.io wrote:
> In line with the changes proposed in #25988, I'd like to propose to change the default behaviour for clicking on entries in the repository to showing the entry's contents, rather than it's history. The research we did at "Planio":https://plan.io showed that viewing is the more common action. GitHub and Bitbucket use the same behaviour, by the way.
I agree. This could really reduce the required number of clicks to get to the content (which is IMHO indeed a valid drawback of the current implementation).
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Patches are committed, thanks.
--------------------------------------------------------------------------------
related_issues
relates,New,25357,"Raw view" of a file in repository
relates,Closed,14332,[Repository] Make "view file" the default
blocks,Closed,26035,More visually consistent download links