Vote #78512
完了Set default assignee before validation
0%
説明
Currently the default assignee is set only after validations. This means that when the field is required the default assignee does not work.
The following patch changes setting the default assignee to before the validation:
diff --git a/app/models/issue.rb b/app/models/issue.rb
index 7d411fc94..a5ebfbffa 100644
--- a/app/models/issue.rb
+++ b/app/models/issue.rb
@@ -105,8 +105,8 @@ class Issue < ActiveRecord::Base
end
}
+ before_validation :default_assign, on: :create
before_validation :clear_disabled_fields
- before_create :default_assign
before_save :close_duplicates, :update_done_ratio_from_issue_status,
:force_updated_on_change, :update_closed_on, :set_assigned_to_was
after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}
journals
I can reproduce the problem as follows.
I confirmed that the problem is reproducible and can be fixed by the pasted patch.
!{width: 683px; border: 1px solid #ccc;}.26072-reproduce.png!
--------------------------------------------------------------------------------
Thank you for confirming this.
Please be aware that this also affects the newly introduced project default assignee, i.e. if an assignee is required and the project has a default assignee the issue will not be created.
Maybe it would be better to make this more explicit by change the "assignee" field to the default project assignee on new issues, and by changing the assignee when changing the category if the assignee wasn't changed yet.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Fix committed in r16619 with a test.
Felix Schäfer wrote:
> Maybe it would be better to make this more explicit by change the "assignee" field to the default project assignee on new issues, and by changing the assignee when changing the category if the assignee wasn't changed yet.
Agreed, it would be an interesting improvement.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
relates,Closed,482,Default assignee on each project
relates,New,26680,Show default assignee when creating new issue