Vote #78524
完了Allow to filter by any visible version on the global issues view
0%
説明
Currently, the global issues view only allows to filter by system-shared versions but not e.g. for versions shared to some projects or not stared at all.
Since the global issue view is often used as a quick filter to check what is happening in all projects, filtering by any visible version would allow to drill down from there instead of having to first select the correct parent project and then starting the filter there. Also, with saved shared queries, a common starting point is the global issue view instead of individual projects.
The attached patch removes the restriction to only allow filtering by system-shared versions. Instead, it allows filtering by any version visible to the current user.
journals
I find this a nice addition indeed. Setting target to unplanned.
--------------------------------------------------------------------------------
As for the rationale, this patch implements the same behavior as for custom fields (in #25501) and for categories (in #26023).
--------------------------------------------------------------------------------
The proposed behavior is also consistent with #24769 (user type custom field).
--------------------------------------------------------------------------------
Mischa The Evil wrote:
> I find this a nice addition indeed. Setting target to unplanned.
I think we can merge this patch right now. Mischa, what do you think about setting target version to 3.4.0? Is it OK with you?
--------------------------------------------------------------------------------
Go MAEDA wrote:
> Mischa The Evil wrote:
> > I find this a nice addition indeed. Setting target to unplanned.
>
> I think we can merge this patch right now. Mischa, what do you think about setting target version to 3.4.0? Is it OK with you?
My two cents:
I'm in favor to set the version:3.5.0 in order to have the version:3.4.0 released as soon as possible.
--------------------------------------------------------------------------------
> My two cents:
> I'm in favor to set the version:3.5.0 in order to have the version:3.4.0 released as soon as possible.
Oh, yes please! Good idea. 3.4.0 matured enough. I have started a discussion about that message#52798 since we are waiting so long now.
My two cents. Total now: 4 cents ;-)
--------------------------------------------------------------------------------
Not to spoil anything here, but this patch here won't result in any delay in getting version:3.4.0 released. It is a tiny patch which helps resolve (together with #24769, #25501 and #26023) some inconsistencies in the way the global filters work. It takes about 5 minutes of work to merge (and backport) this and several of the other already assigned patches.
In general, there's no gain from having tiny patches wait for the next release. Instead, the release is (probably) only delayed by the larger open issues which still take some thinking, or review plus whatever JPL already has in his sleeves.
--------------------------------------------------------------------------------
Holger, I'm happy about any new Redmine feature! If it's really such a small task applying that patch, then they should do it. I'm just a bit afraid that there is actually more to do. Already the communication here has to be done, thinking about it, creating a test, ... There should be a point where new things get added to the next version, otherwise 3.4.0 might be released next year ;-) Now I shut up.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
As mentioned in #26091#note-2 and #26091#note-3, the behaviour of this patch is consistent with #25501 and #24769. They were already delivered in 3.4.0.
I am setting target version to 4.1.0.
--------------------------------------------------------------------------------
Committed. Thank you for improving Redmine.
--------------------------------------------------------------------------------
I'm reopening and assigning this to me because I would like to add a test for this feature.
--------------------------------------------------------------------------------
Here is the updated test.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Better test name.
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> Better test name.
Sorry, I have committed the previous patch. Do you think I should change the test name?
--------------------------------------------------------------------------------
Go MAEDA wrote:
> Marius BALTEANU wrote:
> > Better test name.
>
> Sorry, I have committed the previous patch. Do you think I should change the test name?
I think the new name of the test reflects better what is tested inside it. Also, we should remove the blank line from the end of the test (line 628).
Me sorry because I didn't pay enough attention when I've updated the patch.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Committed. Thank you all for the contribution.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
relates,New,26023,Category filter only shows categories of current project
relates,Closed,3869,Filter using Target Version loses 'Target Version' part of the filter when applied across all tickets.