Vote #78535
完了Refactor "multiple_values_detail" struct creation
0%
説明
Hi,
In the "IssuesHelper#details_to_strings":/projects/redmine/repository/entry/trunk/app/helpers/issues_helper.rb method (source:trunk/app/helpers/issues_helper.rb@16387#L373) a new class (Struct) is created each time the method is called:
multiple_values_detail = Struct.new(:property, :prop_key, :custom_field, :old_value, :value)
Although classes are garbage collected in recent Ruby versions, it might be better to use a constant definition outside the method, like:
MultipleValuesDetail = Struct.new(:property, :prop_key, :custom_field, :old_value, :value)
Regards,
Thomas
journals
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Change committed, thanks.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
I think target version should be version:3.5.0 because there is no 3.5-stable in Subversion.
--------------------------------------------------------------------------------
Admin Redmine さんが約4年前に更新
- カテゴリ を Code cleanup/refactoring_30 にセット
- 対象バージョン を 4.0.0_99 にセット