Vote #78541
完了Remove duplicate method shell_quote
0%
説明
There are two identical methods @shell_quote@ declared in @Redmine::Utils::Shell@ and @Redmine::Scm::Adapters::AbstractAdapter@.
This patch removes the duplicate declaration from @AbstractAdapter@ and also extracts a generic @shell_quote_command@ method into @Redmine::Utils::Shell@.
journals
Jens Krämer wrote:
> There are two identical methods @shell_quote@ declared in @Redmine::Utils::Shell@ and @Redmine::Scm::Adapters::AbstractAdapter@.
Indeed. Those two methods are completely identical. The patch looks good to me and passed all tests.
Setting target version to 3.4.0.
--------------------------------------------------------------------------------
Committed, thanks!
--------------------------------------------------------------------------------
Admin Redmine さんが約4年前に更新
- カテゴリ を Code cleanup/refactoring_30 にセット
- 対象バージョン を 3.4.0_119 にセット