プロジェクト

全般

プロフィール

Vote #78598

完了

Don't display file download button while on repository directory entries

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
UI_10
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
10
version_id:
130
issue_org_id:
26350
author_id:
1565
assigned_to_id:
1
comments:
2
status_id:
5
tracker_id:
1
plus1:
0
affected_version:
closed_on:
affected_version_id:
119
ステータス-->[Closed]

説明

As the subject states, the file download button is also displayed on repository directory entries. This obviously shouldn't be the case.
This issue has been introduced with r16672 for #26035.

I'll attach a small patch fixing the issue. I've included the addition of a test assertion (for Git) showcasing the issue. I am not sure what is the best place to test this properly, so I've left multiple of such assertions out of the other adapters.

The patch, against source:/trunk@16749, is produced using @git format-patch@ which makes it apply-able using "@patch -p1 < 0001-...@".

Environment:

Environment:
  Redmine version                3.4.0.devel@r16749
  Ruby version                   2.3.3-p222 (2016-11-21) [x86_64-linux]
  Rails version                  4.2.8
  Environment                    production
  Database adapter               Mysql2
SCM:
  Subversion                     1.8.8
  Git                            1.9.1
  Filesystem                     
Redmine plugins:
  no plugin installed

journals

--------------------------------------------------------------------------------
Fix committed, thanks.
--------------------------------------------------------------------------------


related_issues

relates,Closed,26035,More visually consistent download links

Admin Redmine さんが3年以上前に更新

  • カテゴリUI_10 にセット
  • 対象バージョン3.4.1_130 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0