プロジェクト

全般

プロフィール

Vote #78627

完了

The second and subsequent lines of commit messages are not displayed in repository browser

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
SCM_3
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
3
version_id:
133
issue_org_id:
26403
author_id:
332
assigned_to_id:
1
comments:
12
status_id:
5
tracker_id:
1
plus1:
1
affected_version:
closed_on:
affected_version_id:
119
ステータス-->[Closed]

説明

After r16062, only the first line of a commit message is displayed in revisions list of the repository browser.

In my opinion, repository browser should not truncate commit messages because it often contain important information for developers.

I hope that this change will be undone in 3.4.2.

Redmine 3.3:
!{width: 730px}.revisions-3_3@2x.png!

Redmine 3.4:
!{width: 730px}.revisions-3_4@2x.png!


journals

But your patch shows *all* text.
Redmine 3.3 truncates to 255 chars.
source:tags/3.3.4/app/helpers/repositories_helper.rb#L29
--------------------------------------------------------------------------------
This problem stops my team from updating to 3.4.0.
I hope this will be fixed as soon as possible.
--------------------------------------------------------------------------------
Yuichi Ishii wrote:
> This problem stops my team from updating to 3.4.0.
> I hope this will be fixed as soon as possible.

Do you really need to see more than the first line of the message in the revision list? The full commit message is still visible on the commit details view.
--------------------------------------------------------------------------------
> Do you really need to see more than the first line of the message in the revision list? The full commit message is still visible on the commit details view.

Thanks for the reply. Yes, we really do.
Most of our commit messages contain more than one line, and reviewers use the repository browser in order to see recent commits roughly.
--------------------------------------------------------------------------------
+1
I agree with the need for multi line display of the repository browser.
(It is also possible with option setting)

Traceability for tickets and changing source code is necessary for maintenance efficiency.

In order to investigate the outline of source code change details later .
It is necessary to use multiple line and new line , to make it easy to see.

If you force it into one line, it becomes difficult to grasp the contents

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Should we truncate at 255 characters (which was the behaviour in all prior versions) or display the full commit message in the revision list?
--------------------------------------------------------------------------------
I think truncating at some characters is better because full text is very annoying.

https://www.mercurial-scm.org/repo/hg/shortlog/4.3-rc

!hg.png!

--------------------------------------------------------------------------------
What about displaying the first line with a toggle button that would show the full commit message?
--------------------------------------------------------------------------------
> What about displaying the first line with a toggle button that would show the full commit message?

Thank you for this nice idea. But the 3.3 or older versions style is better for us.
Because it helps us see outlines of commit messages easily.
--------------------------------------------------------------------------------
r16843 restores the same behaviour as 3.3 for displaying commit messages in the revision list.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

Admin Redmine さんが3年以上前に更新

  • カテゴリSCM_3 にセット
  • 対象バージョン3.4.3_133 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0