プロジェクト

全般

プロフィール

Vote #78639

未完了

CSS formating classes like p(box). prepended with wiki-class-

Admin Redmine さんが約4年前に追加. 約4年前に更新.

ステータス:
Needs feedback
優先度:
通常
担当者:
-
カテゴリ:
Text formatting_26
対象バージョン:
-
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
26
version_id:
0
issue_org_id:
26442
author_id:
152240
assigned_to_id:
1565
comments:
10
status_id:
10
tracker_id:
1
plus1:
0
affected_version:
closed_on:
affected_version_id:
130
ステータス-->[Needs feedback]

説明

This worked in the 3.3 trunk, updated to 3.4 and box's are no longer there but text is still displayed.

This method of text formatting was taken from the "Mastering Redmine Book" page 322.


journals

Please describe more details.
--------------------------------------------------------------------------------
!Capture.PNG!

This worked in 3.3, but does not in 3.4
--------------------------------------------------------------------------------
I cannot reproduce.

!source.png!

!html.png!
--------------------------------------------------------------------------------
Toshi, I can confirm it. As is also visible in the screenshot from the referenced book, before r16502 it was possible to reuse the core CSS classes (like @box@, @conflict@, etc.) in the content. This is not possible any longer after r16502, as these classes get @wiki-class-@ prefixed as visible in your screenshot.
--------------------------------------------------------------------------------
Mischa The Evil wrote:
> Toshi, I can confirm it. As is also visible in the screenshot from the referenced book, before r16502 it was possible to reuse the core CSS classes (like @box@, @conflict@, etc.) in the content. This is not possible any longer after r16502, as these classes get @wiki-class-@ prefixed as visible in your screenshot.

Yes, the change was made on purpose in order to prevent arbitrary CSS classes from being used in formatted text. It was reported as a vulnerability and fixed in 3.4.

All user entered CSS classes are now prefixed with @wiki-class-@ and ids with @wiki-id-@. We can still add support for some of them in the default stylesheet. It will be better to have dedicated CSS classes for formatted text instead of using those of the core that can change.

Can we make a list of usefull classes that should be made available for formatted text?
--------------------------------------------------------------------------------
For what is is worth, I only am aware or use the two that the book mentions: p(box) and p(conflict). Digging into the CSS to understand what options we could have for advanced text formatting and display is not something we have done. The addition of having these two has enhanced the clarity of our document / issue presentation so having them is nice. Possibly there are others as well that could be useful but I have not seen any documentation on what they may be, and I do not have sufficient base knowledge of where to go looking for them or the need.

--------------------------------------------------------------------------------
I'll take a look at this.
--------------------------------------------------------------------------------
Is there anything I can do to help support this issue? I'm assuming others have used this feature in the past, especially being that it was published in the Mastering Redmine book. p(conflict) and p(box) are currently the only ones I'm familiar with.

I do like Jean-Philippe's comment about having a published list that we (users) can reference. If it was published it would greatly enhance peoples ability to create rich content in redmine. Being that there is no new CSS, it is just using vetted code, there is little maintenance overhead added to having these methods available to the users.

--------------------------------------------------------------------------------
Is there an update to this? Our organization has metric-ton of wikis and tickets in Redmine that use p(conflict) and p(box), as others have said, because they're really nice and convenient. Looking to update soon, too, and hoping that we can just jump to 3.4.7 with this function/equivalent restored ;-)
--------------------------------------------------------------------------------
Is there a way to patch issues with the current system to get the site wide CSS p(box) and p(conflict) to work again with wiki-class prefixes added to them? Would it be appropriate to add that to our current theme's style sheet to regain support for this very useful formatting feature again?
--------------------------------------------------------------------------------

Admin Redmine さんが約4年前に更新

  • カテゴリText formatting_26 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0