Vote #78665
完了"attachment:filename" link syntax would not work if the file name contains "@"
0%
説明
A file name which contains "@" is treated as email address.
Probably all versions that support "attachment:filename" syntax are affected. redmine.org is also affected. Please see this example: attachment:wrong-attachment-link@2x.png
[Textile]
attachment:image@2x.png
[Expected output]
image@2x.png
[Actual output]
attachment:image@2x.png
!{width: 330px; border: 1px solid #ccc;}.wrong-attachment-link@2x.png!
journals
I can work on this, but the fix will be based on the one from #26443.
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> I can work on this, but the fix will be based on the one from #26443.
Sounds great. I set the target version of #26443 to 3.4.3. Could you write a patch?
--------------------------------------------------------------------------------
Go MAEDA wrote:
> Sounds great. I set the target version of #26443 to 3.4.3. Could you write a patch?
Here it is. In order to apply this patch, you need to apply first the patch from #26443.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
The patch looks good to me and passed all tests.
Setting target version to 3.4.3.
Marius, thank you for writing the patch.
--------------------------------------------------------------------------------
Updated the patch to work with the latest changes from #26443.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
#26443 is now set for 4.0.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Updated the patch to apply cleanly against current trunk (r17286).
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Thanks Marius.
--------------------------------------------------------------------------------
related_issues
relates,Closed,27968,Image filename for HDPI monitors (image@2x.jpg) are misrecognized as email address
blocks,Closed,26443,User link syntax (user:login) doesn't work for logins consisting of an email adress