プロジェクト

全般

プロフィール

Vote #78675

完了

Repository routing bug when file path starts with (browse|entry|raw|changes|annotate|diff)/

Admin Redmine さんが4年以上前に追加. 4年以上前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
SCM_3
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
3
version_id:
99
issue_org_id:
26522
author_id:
40856
assigned_to_id:
1
comments:
3
status_id:
5
tracker_id:
3
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

If the first component of a path in a repository equals one of the strings above, the wrong route gets selected in the case of links without @repository_id@ (as they are generated from wiki @source:@ links to the default repository of a project) and the intended action is mistaken for the @repository_id@ parameter. Attached is a patch to the repository routing test illustrating the issue.

I would suggest to change repository#identifier_param to always return an identifier (see second patch) and remove the repository routes without repository_id (rows 280ff in current config/routes.rb).


journals

--------------------------------------------------------------------------------
Routes without repository_id are removed.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------


related_issues

relates,New,35885,the change of routing raw files from repositories not included in the upgrade proces/manual

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0