Vote #78688
完了Allow "max-height", "max-width", "min-height" and "min-width" CSS properties in Textile
0%
journals
--------------------------------------------------------------------------------
I suggest applying this patch (that's why I wrote it).
--------------------------------------------------------------------------------
Thank you for suggesting the improvement.
I almost agree with you, "max-width" property is beneficial. But I think "max-height" should be available as well. Probably users believe they can also use "max-height" if Redmine supports "max-width". I have slightly modified your patch to support "max-height".
--------------------------------------------------------------------------------
Setting target version to 4.1.0.
--------------------------------------------------------------------------------
Updated the patch to support min-width and min-height. Now the patch supports properties as follows:
* min-width
* min-height
* max-width
* max-height
--------------------------------------------------------------------------------
Added tests to the patch.
--------------------------------------------------------------------------------
Committed. Thank you for suggesting this improvement and sharing your patch.
--------------------------------------------------------------------------------
Go MAEDA wrote:
> Added tests to the patch.
I would suggest to add the same two tests also for max-height and height.
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> Go MAEDA wrote:
> > Added tests to the patch.
>
> I would suggest to add the same two tests also for max-height and height.
I agree.
--------------------------------------------------------------------------------
Marius and Mischa, thank you for pointing it out. Here is a patch to add tests for "height" and "max-height".
--------------------------------------------------------------------------------
Go MAEDA wrote:
> Marius and Mischa, thank you for pointing it out. Here is a patch to add tests for "height" and "max-height".
Looks good to me.
--------------------------------------------------------------------------------
Committed tests for "height" and "max-height" in r17175.
--------------------------------------------------------------------------------