プロジェクト

全般

プロフィール

Vote #78698

完了

Add update info at the bottom of the wiki page

Admin Redmine さんが約4年前に追加. 約4年前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
Wiki_1
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
1
version_id:
99
issue_org_id:
26575
author_id:
332
assigned_to_id:
1
comments:
15
status_id:
5
tracker_id:
2
plus1:
2
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

!{width: 716px}.wiki-update-info@2x.png!


journals

Implemented in r16905.
--------------------------------------------------------------------------------
I propose to add some links to the user name and date (for consistency with other screens).

*Before:*
!before.png!

*After:*
!after.png!
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> I propose to add some links to the user name and date (for consistency with other screens).

+1
@time_tag@ is really needed to know detailed updated time.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
Patch committed, thanks.
--------------------------------------------------------------------------------
Hello.
I am trying to translate "label_x_revisions" in .yml and I have a question.
Why did you called this label "revisions" (like in "Repository" module) but not "versions" (like in wiki history) ?
!redmine_wiki_version.PNG!
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Wiki history now uses "Revisions" only.
--------------------------------------------------------------------------------
I think that showing the familiar "history" icon is better. If there is the icon, users can find the important link easily and can understand that the "X revisions" is the link that they used to call "History" link.

Without the icon, users may not be able to find this feature and misunderstand that "History" has been removed.

<pre><code class="diff">
Index: app/views/wiki/show.html.erb
===================================================================
--- app/views/wiki/show.html.erb (revision 17516)
+++ app/views/wiki/show.html.erb (working copy)
@@ -74,7 +74,7 @@
<% if User.current.allowed_to?(:view_wiki_edits, @project) %>
<p class="wiki-update-info">
<%= wiki_content_update_info(@content) %>
- · <%= link_to l(:label_x_revisions, :count => @content.version), {:action => 'history', :id => @page.title} %>
+ · <%= link_to l(:label_x_revisions, :count => @content.version), {:action => 'history', :id => @page.title}, {:class => 'icon icon-history'} %>
</p>
<% end %>

</code></pre>

*Redmine 3.4:*
We had an icon beside the History link.
!{width: 777px; border: 1px solid #ccc;}.redmine-3_4@2x.png!

*The current trunk (Redmine 3.4.6.devel.17516):*
"History" was changed to "X revisions" and the icon was removed.
!{width: 777px; border: 1px solid #ccc;}.redmine-4_0-without-icon@2x.png!

*The current trunk with the proposing patch:*
Adding the icon is intuitive and consistent with older versions.
!{width: 777px; border: 1px solid #ccc;}.redmine-4_0-with-icon@2x.png!
--------------------------------------------------------------------------------
Would it be confusing/a problem to keep the "History" button above? I think the information below is a great addition, but the button on the top would allow easy access to the history (without the need to scroll down)- and all other "control" elements are there, too.

As an imho: In that case I'd drop the icon below, I think it looks more elegant. But I am not an UI/UX expert ;-)
--------------------------------------------------------------------------------
I am +1 for keeping the "History" link at the top, in addition to the new controls at the bottom.
--------------------------------------------------------------------------------
Hi, Sound good to me to keep it.
--------------------------------------------------------------------------------
History link restored at the top of the page.
--------------------------------------------------------------------------------

Admin Redmine さんが約4年前に更新

  • カテゴリWiki_1 にセット
  • 対象バージョン4.0.0_99 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0