Vote #78729: git 2.14 compatibility - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #78729

完了

git 2.14 compatibility

Admin Redmine さんが4年以上前に追加. 4年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

SCM_3

対象バージョン:

3.3.5_131

開始日:

2022/05/09

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/26645

category_id:

version_id:

131

issue_org_id:

26645

author_id:

9075

assigned_to_id:

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

132

ステータス-->[Closed]

引用

説明

There is no "--no-color" argument for "git version" anymore.

Potential fix:


Index: lib/redmine/scm/adapters/git_adapter.rb
===================================================================
--- lib/redmine/scm/adapters/git_adapter.rb     (revision 16828)
+++ lib/redmine/scm/adapters/git_adapter.rb     (working copy)
@@ -54,7 +54,7 @@
           end
 
           def scm_version_from_command_line
-            shellout("#{sq_bin} --version --no-color") { |io| io.read }.to_s
+            shellout("#{sq_bin} --version") { |io| io.read }.to_s
           end
         end

journals

--------------------------------------------------------------------------------
<pre>
$ ./git --version
git version 2.14.0
$ ./git --version --no-color
error: unknown option `no-color'
usage: git version [<options>]

--build-options also print build options

$ ./git log --no-color | wc
753470 3494163 28722346
$ ./git log | wc
753470 3494163 28722346
$ ./git config -l | grep color
color.ui=true
</pre>
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
I have committed r16948.
We cannot use self.superclass.client_version_above? because "git --version --no-color" fails.
I think I added "--no-color" to "git --version" at r4885 for preventing feature brokenness.
--------------------------------------------------------------------------------
Committed in turnk, 3.4-stable, and 3.3-stable.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

related_issues

relates,Closed,5324,Git not working if color.ui is enabled
relates,Reopened,29416,Do not show Git revisions
duplicates,Closed,26765,Redmine 3.3.3.stable Cannot find binary for Git 2.14