Vote #78735: Additional icon for contextmenu - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #78735

完了

Additional icon for contextmenu

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

UI_10

対象バージョン:

4.0.0_99

開始日:

2022/05/09

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/26655

category_id:

version_id:

issue_org_id:

26655

author_id:

121548

assigned_to_id:

332

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

The contextmenu is a very helpful feature that can increase the productivity while working with redmine. Many people don't know of this great feature because it is only triggered by a right mouse click, which is not a common user interaction on the web. In order to make this feature more prominent this patch adds an icon to table rows that have a contextmenu, which allows to trigger the appearance of the contextmenu with a regular mouse click.

As there was no icon with three dots available in the famfamfam available, we created our own by using an existing icon with a dot.

This gif shows this new icon in action on the issues table:

!contextmenu.gif!

journals

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
+1

Felix Gliesche wrote:
> Many people don't know of this great feature because it is only triggered by a right mouse click, which is not a common user interaction on the web.

I think it is exactly right. It is very good idea to make the context menu obvious.
--------------------------------------------------------------------------------
You're absolutely right. Context menu is not used, too "hidden". This is a very good solution.
--------------------------------------------------------------------------------
The patch is based on user research we did for "Planio Redmine Hosting":https://plan.io/redmine-hosting/. We also surveyed a number of other platforms which use item list representations and context menus (Dropbox, Nextcloud, box.net, etc.). A horizontal three dotted icon seems by far to be the most common trigger for a context menu these days. Right click without alternative was only present in a few examples (e.g. Google Drive). The feature will be rolling out at Planio soon and I would love for this to become part of Redmine as well!
--------------------------------------------------------------------------------
The icon greatly improves usability.
Setting target version to 4.1.0.
--------------------------------------------------------------------------------
Very nice feature, especially that it will make the context menu available on the mobile.

It looks good also with a vertical three dotted icon.
!vertical.png!
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> It looks good also with a vertical three dotted icon.

This would be confusing as the vertical dots are already used as drag and drop handlers for trackers, enumerations, statuses and so on.
--------------------------------------------------------------------------------
Felix Schäfer wrote:
> Marius BALTEANU wrote:
> > It looks good also with a vertical three dotted icon.
>
> This would be confusing as the vertical dots are already used as drag and drop handlers for trackers, enumerations, statuses and so on.

From my knowledge, the drag and drop handlers have a green arrow as icon. Anyway, it is not so important how the dots are displayed, both options look good to me and also, the dots can be easily rotated only from CSS. I just wanted to point out this alternative.

--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> From my knowledge, the drag and drop handlers have a green arrow as icon.

You are right, I am sorry, the 3 dots are used in a theme, and vertical dots are used as drag and drop handlers in Gmail for example too.
--------------------------------------------------------------------------------
I am attaching an updated patch, that sets correct colspan when grouping issue lists.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
FYI:
"Mastodon":https://github.com/tootsuite/mastodon (social network server) uses horizontal three dots button for context menu.

!{width: 312px;}.mastodon-context-menu-button@2x.png!
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
I made a slight change to the patch because I couldn't apply to the current trunk (r16971 and later).

And the patch doesn't include @3_bullets.png@, so I stole the icon from "Planio":https://support.plan.io/images/3_bullets.png :)
--------------------------------------------------------------------------------
I found a small problem that the context menu icon is displayed in a wrong position for subtasks. No problem for related issues. I also confirmed the very similar problem in my Planio account.

Felix Gliesche, could you fix this?

!{width: 626px; border: 1px solid #ccc;}.icon-for-subtasks@2x.png!
--------------------------------------------------------------------------------
Go MAEDA wrote:
> I found a small problem that the context menu icon is displayed in a wrong position for subtasks. No problem for related issues. I also confirmed the very similar problem in my Planio account.
>
> Felix Gliesche, could you fix this?
>

Sure, I'll have a look into it.

--------------------------------------------------------------------------------
I am uploading a patch, that should apply to the current trunk. The problem, you are referencing to is related to missing mobile optimiziation. I added missing styles to @public/stylesheets/responsive.css@ as you can see in the updated version of the patch.

--------------------------------------------------------------------------------
I had to update the patch (see attached). Could you please delete the previous one, to avoid confusion?
--------------------------------------------------------------------------------
I found, that the text shines through, due to right padding, which is not necessary on mobile devices. I removed this, whit this updated patch. Please use this one ;)
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Thank you for updating the patch. Now it works perfectly. I think this feature should be a part of Redmine 4.0 / 4.1.
--------------------------------------------------------------------------------
Committed. Thank you for sharing this great improvement.
--------------------------------------------------------------------------------
Reverted r17252 and r17253 because the patch breaks the test suite.
--------------------------------------------------------------------------------
After applying the patch, an exception is raised if a user who does not have "Manage related issues" permission opens an issue with one or more related issues. You can also confirm the problem by running test/functional/issues_controller_test.rb.

But I noticed that this bug has already fixed in Planio. Could you kindly provide a patch based on the current Planio's code base?
--------------------------------------------------------------------------------
Go MAEDA wrote:
> After applying the patch, an exception is raised if a user who does not have "Manage related issues" permission opens an issue with one or more related issues. You can also confirm the problem by running test/functional/issues_controller_test.rb.
>
> But I noticed that this bug has already fixed in Planio. Could you kindly provide a patch based on the current Planio's code base?

Sure, I will have a look into it. Already working on the patch, so that it does not break the test suite.
--------------------------------------------------------------------------------
Go MAEDA wrote:
> Committed. Thank you for sharing this great improvement.

I am uploading the updated patch. It does not break the test suite and fixes the problem for users without the "manage related issues" permission that you mentioned.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Committed. Thank you so much for updating the patch.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

related_issues

relates,New,5711,Make Bulk Edit menu more apparent...
relates,Reopened,28829,Add right-click context menu to the contextual area of an issue
duplicates,Closed,1590,Awkward way of accessing shortcut menu in issue list
duplicates,Closed,5739,Direct access to Issue update from issue list
duplicates,Closed,29074,Add "Edit" function to entries in "Spent Time" block appropriately