I agree that adding classes is a nice improvement for theme developers. But I think that class names such as "query-column-header query-column-header-issue" is long and "query-column-header issue" is enough.

What do you think?
--------------------------------------------------------------------------------
Go MAEDA wrote:
> I agree that adding classes is a nice improvement for theme developers. But I think that class names such as "query-column-header query-column-header-issue" is long and "query-column-header issue" is enough.
>
> What do you think?

Class name contained only column name is not enough to specify context. It may be used in another parts of application and its style will be attached to query-column-header too. For example: if we have column with name 'highlight' then column header will be with background (@.highlight { background-color: #FCFD8D;}@ from application.css).
--------------------------------------------------------------------------------
I think we should use the existing `css_classes` method to generate also the classes for query column headers. In this way, both type of cells (th and td) will have the same classes and we can easily target them from CSS. Attach is a patch that implements this and adds multiple assertions.

Regarding the proposed classes, the length is not a problem from my point of view, but we should be consistent with the existing implementations and if we want to change the class name because is not enough to specify the context, the change should apply also for tds.
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> I think we should use the existing `css_classes` method to generate also the classes for query column headers

I agree. I prepare new issue with modifications of @css_classes@ but in redmine css we have problem with specify everywhere and we need to fully rewrite @application.css@. All that fixes will broke all existed redmine themes, so I think that it need to be fixed it in a complex way and only for next major version.
--------------------------------------------------------------------------------
Dmitry Lisichkin wrote:
> I agree. I prepare new issue with modifications of @css_classes@ but in redmine css we have problem with specify everywhere and we need to fully rewrite @application.css@. All that fixes will broke all existed redmine themes, so I think that it need to be fixed it in a complex way and only for next major version.

Totally agree. Until then, this issue can be implemented.
--------------------------------------------------------------------------------
Can we set target 4.0 or 4.1?
--------------------------------------------------------------------------------
Toshi MARUYAMA wrote:
> Can we set target 4.0 or 4.1?

I am in favor of #26674#note-3. The patch is simple and consistent with existing classes. I think we can merge it to the trunk.
--------------------------------------------------------------------------------
Go MAEDA wrote:
> Toshi MARUYAMA wrote:
> > Can we set target 4.0 or 4.1?
>
> I am in favor of #26674#note-3. The patch is simple and consistent with existing classes. I think we can merge it to the trunk.

Totally agree.
--------------------------------------------------------------------------------
Setting target version to 4.1.0.
--------------------------------------------------------------------------------
Committed. Thank you for you all's contribution.
--------------------------------------------------------------------------------