Vote #78755: Anonymous user should have their icon - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #78755

完了

Anonymous user should have their icon

Admin Redmine さんが4年以上前に追加. 4年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

UI_10

対象バージョン:

3.3.6_136

開始日:

2022/05/09

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/26699

category_id:

version_id:

136

issue_org_id:

26699

author_id:

332

assigned_to_id:

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

@ApplicationHelper#avatar@ method returns blank string instead of @img@ tag for the anonymous user. The behavior causes disordered layout in IssuesController#show page.

This patch adds an icon for the anonymous user and fixes the broken layout.

Before:
The author of the issue is the anonymous user. But in the upper left corner of the page, the assignee's icon is displayed as if it is the author's icon because the anonymous user does not have their avatar icon.
!{width: 320px; border: 1px solid #ddd;}.before1@2x.png!

No icon is displayed in the journal which was made by the anonymous user.
!{width: 320px; border: 1px solid #ddd;}.before2@2x.png!

After:
New anonymous icon is displayed.
!{width: 320px; border: 1px solid #ddd;}.after1@2x.png!

!{width: 320px; border: 1px solid #ddd;}.after2@2x.png!

journals

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Updated tests.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
I think it is problematic that an assignee's icon looks like an author's icon in Redmine 3.4 when the issue's author is an anonymous user.

I suggest including this fix in 3.4.3.
--------------------------------------------------------------------------------
I think it would be better to use the default gravatar icon instead of using our own.
What do you think?
--------------------------------------------------------------------------------
Jean-Philippe Lang wrote:
> I think it would be better to use the default gravatar icon instead of using our own.
> What do you think?

I prefer to have a special icon for anonymous user. We cannot distinguish a regular user with no Gravatar icon and anonymous user if default Gravatar icon is used for anonymous users.
--------------------------------------------------------------------------------
Go MAEDA wrote:
> [...]
>
> I prefer to have a special icon for anonymous user. We cannot distinguish a regular user with no Gravatar icon and anonymous user if default Gravatar icon is used for anonymous users.

I agree with Go MEADA on this. We should be able to distinguish between regular users without Gravatar and anonymous user(s).
--------------------------------------------------------------------------------
Committed, thanks.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

related_issues

relates,Closed,25775,Show assignee's icon in addition to author's icon
relates,Closed,28204,Too large avatar breaks gantt when assignee is a group
relates,Closed,28208,Anonymous icon is wrongly displayed when assignee is a group