Vote #78788
完了Issue filtering by spent time
0%
説明
Hi!
Here's a patch that adds a filter for spent time to IssueQuery. Any chance this could be included in the next 3.3 and 3.4 versions?
journals
Here's an updated patch based on feedback that meineerde gave me on IRC.
* An unknown operator leads to invalid SQL, @return nil@ early instead
* @NUMERIC@ is a non-standard PostgreSQL type, use @DECIMAL@ instead
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
I think it would be better to move the position of "Spent time" filter in the filters list. The reasons are as follows:
* The proposed patch places the filter in the third position. I think it is a too excellent position for the filter because most users don't use the filter so frequently.
* "Spent time" and "Estimated time" are closely related to each other. These two filters should be next to each other.
Attaching an updated patch.
*Before:*
!{width: 232px}.26826-note4-before@2x.png!
*After:*
!{width: 232px}.26826-note4-after@2x.png!
--------------------------------------------------------------------------------
I tested the patch "issue-filter-by-spent-time-3.diff" posted by Go Maeda.
As a result, I found that it is necessary to add a fixture of time_entrys to the test code "test/unit/query_test.rb".
Tests were done with MySQL, PostgreSQL, SQLite and all succeeded.
I attach a new patch that added fixture.
--------------------------------------------------------------------------------
I noticed that 'expected' and 'actual' are reversed on the added assertions.
Attaching an updated patch.
--------------------------------------------------------------------------------
Committed the patch. Thank you for improving Redmine.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
relates,New,35798,Add Total estimated/spent time issue query filters
duplicates,Closed,13947,Add spent time issue list filter