Vote #78839
完了Mark non-working days in calendar view
0%
説明
In global settings, we can set which are / are not working days - it should be nice to have it visually marked in project's calendar view
journals
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Maybe we can grey-out the non working days using the same style like the days from other months? Something like that:
!{width: 50%; border: 1px solid grey}.non-working-days.png!
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> Maybe we can grey-out the non working days using the same style like the days from other months?
+1
I think it would be even better to use a different background color from dates of previous/next months.
--------------------------------------------------------------------------------
Go MAEDA wrote:
> +1
> I think it would be even better to use a different background color from dates of previous/next months.
Yes, it could be an option. Let me see what can I do.
--------------------------------------------------------------------------------
Go Maeda, attached the patches that mark the non working days in the calendars from Projects and My Page. I didn't apply any style on the class because I didn't have any idea (apart from the same style as the one from days from other month). Please feel free to add a style to my patches.
--------------------------------------------------------------------------------
Go Maeda, did you have the chance to look over this feature?
--------------------------------------------------------------------------------
Marius, thank you for writing the patch.
It looks OK except one thing. Do you think it is OK that the class name for non-working days is different from gantt? Although gantt already uses "nwday", your patch uses "non-working".
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Go MAEDA wrote:
> It looks OK except one thing. Do you think it is OK that the class name for non-working days is different from gantt? Although gantt already uses "nwday", your patch uses "non-working".
For sure we should use the existing "nwday" class, but I didn't know about it. I've updated my second patch, thanks for pointing out.
Tests results here: https://gitlab.com/marius-balteanu/redmine/-/jobs/142133626
--------------------------------------------------------------------------------
Thank you for updating the patch, it looks good. Setting the target version to 4.1.0.
--------------------------------------------------------------------------------
Committed the patches. Thank you for improving Redmine.
And I have added a style for non-working days. The background color is the same with non-working days in gantt.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------