Vote #78912
未完了Use the new pagination style for the calendars view
0%
説明
This patch converts the previous and next month links in the calendars view into buttons in the new pagination style. It also aligns the buttons vertically with the input fields on the left.
journals
This is the result of the patch...
---
!screenshot_calendars_buttons.png!
---
--------------------------------------------------------------------------------
It looks nice and improves the consistency of UI. I am setting target version to 4.1.0.
Thank you for posting the patch.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
This is another small change that can be included in version:"4.0.0".
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> This is another small change that can be included in version:"4.0.0".
I have not committed this patch because this patch changes a style ".buttons". The change influences all pages which use the class, not only the calendar page.
--------------------------------------------------------------------------------
Go MAEDA wrote:
> Marius BALTEANU wrote:
> > This is another small change that can be included in version:"4.0.0".
>
> I have not committed this patch because this patch changes a style ".buttons". The change influences all pages which use the class, not only the calendar page.
Oh, I need to admit that I didn't see that change.
--------------------------------------------------------------------------------
I'm currently on the road but I can have a look at the patch on Sunday.
At a first glance I think the new styles came into the patch by accident.
--------------------------------------------------------------------------------
Ok, I've looked at the patch and the style changes for the 'buttons' class are necessary to geht the new buttons for previous and next month in line with the form controls on the left.
After nearly a year passed by since I've submitted this patch I don't think it's the right solution anymore and I'll submit a better one for version:4.1.0.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
relates,Closed,21258,Use <ul> to do pagination, styling in a GitHub like manner with improved handling in responsive mode
Admin Redmine さんがほぼ4年前に更新
- カテゴリ を Calendar_36 にセット
- 対象バージョン を Candidate for next major release_32 にセット