Vote #79021
完了Remove filename from attachment preview links
0%
説明
Some of our users reported being confused by the attachment previews. The most common use-case was a variation of:
right-click on the link of the attachment on the issue page,¶
"save link as" to save the attachment to disk,¶
send the saved file to a user not on the Redmine.¶
With the current URL scheme for attachment preview pages (@/attachments/:id/:filename@), when the users click the preview attachment link instead of the download attachment link, the resulting html file still has the @filename@ of the attachment. If the user does not have a look at the attachment before using it for something else, the user might have downloaded the html preview page instead of the attachment itself.
journals
The attached patch changes the URL rendered to preview pages from @/attachments/:id/:filename@ to @/attachments/:id@. Both URLs work before and after the patch, so this will for example not break plugins or links coming from external sites. The links to the preview attachment pages in Redmine will not have the @filename@ in the URL, thus if a user erroneously downloads that instead of the attachment the downloaded file will be called @123.html@ instead of @image.png@ for example.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
We have to update existing tests to commit this patch.
This is an example:
<pre>
Failure:
ApplicationHelperTest#test_attachment_link_should_link_to_latest_attachment [/Users/maeda/redmines/redmine-trunk/test/helpers/application_helper_test.rb:694]:
--- expected
+++ actual
@@ -1 +1 @@
-"<p><a class=\"attachment\" href=\"/attachments/1100/test.txt\">test.txt</a></p>"
+"<p><a class=\"attachment\" href=\"/attachments/1100\">test.txt</a></p>"
</pre>
--------------------------------------------------------------------------------
Thanks for taking a look at this patch. Attached you may find a diff, which adds the necessary changes to the test suite.
--------------------------------------------------------------------------------
Committed. Thank you for sharing the patches.
--------------------------------------------------------------------------------