Hooman Valibeigi wrote:
> The fix at #8121 is broken as stated in my last comment there.
>
> My environment: Redmine 3.4.2, Google Chrome 63
>
> 1. `p(rtl).` maps to `class="wiki-class-rtl"` in html, but there is no such class in application.css

I think we can change like r16503.

> 2. `unicode-bidi:bidi-override` must be removed or set to `normal`
> See https://www.w3schools.com/cssref/pr_text_unicode-bidi.asp

Which do you think is better?
--------------------------------------------------------------------------------
Toshi MARUYAMA wrote:
> Which do you think is better?

Replacing the following lines in application.xml
<pre>.ltr {direction:ltr !important; unicode-bidi:bidi-override;}
.rtl {direction:rtl !important; unicode-bidi:bidi-override;}</pre>
with these, will fix it
<pre>.wiki-class-ltr {direction:ltr !important;}
.wiki-class-rtl {direction:rtl !important;}</pre>
--------------------------------------------------------------------------------
It would be more appreciated if someone documents the syntax of `p(rtl).` on the wiki
https://www.redmine.org/projects/redmine/wiki/RedmineTextFormattingTextile
--------------------------------------------------------------------------------
Hooman Valibeigi wrote:
> Toshi MARUYAMA wrote:
> > Which do you think is better?
>
> Replacing the following lines in application.xml

Do you mean application.css, not application.xml?

--------------------------------------------------------------------------------
Toshi MARUYAMA wrote:
> Do you mean application.css, not application.xml?

Yes, redmine/public/stylesheets/application.css
--------------------------------------------------------------------------------
I've just noticed that HTML emails sent from Redmine will contain class="wiki-class-rtl" for RTL text, which is not supposed to work because email clients have no access to Redmine css.
--------------------------------------------------------------------------------
The wiki class is fixed by r17260.

> I've just noticed that HTML emails sent from Redmine will contain class="wiki-class-rtl" for RTL text, which is not supposed to work because email clients have no access to Redmine css.

Please open a separate issue as this problem is not specific the .rtl class.
--------------------------------------------------------------------------------
Jean-Philippe Lang wrote:
> The wiki class is fixed by r17260.

You forgot to fix the unicode-bidi:bidi-override; value, must be unicode-bidi:normal; or left unset. bidi-override rotates the English words in a RTL context, therefore word "cat" will be seen as "tac".

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
bidi-override removed in r17280.
--------------------------------------------------------------------------------

relates,Closed,8121,Allow overriding direction of part of text