プロジェクト

全般

プロフィール

Vote #79057

完了

Remove 'unloadable' from bundled sample plugin

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
Plugin API_20
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
20
version_id:
139
issue_org_id:
27963
author_id:
1565
assigned_to_id:
332
comments:
3
status_id:
5
tracker_id:
3
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

Pretty straightforward. After #20513, the statement should be removed from the bundled example plugin too (i.e. r1282 should be reverted). The following raw patch (against source:/trunk@17169) takes care of this:


Index: extra/sample_plugin/app/controllers/example_controller.rb
===================================================================
--- extra/sample_plugin/app/controllers/example_controller.rb   (revision 17169)
+++ extra/sample_plugin/app/controllers/example_controller.rb   (working copy)
@@ -1,7 +1,5 @@
 # Sample plugin controller
 class ExampleController < ApplicationController
-  unloadable
-
   layout 'base'
   before_action :find_project, :authorize
   menu_item :sample_plugin


journals

--------------------------------------------------------------------------------
Committed to the trunk. Thank you for pointing it out.
--------------------------------------------------------------------------------
Merged to 3.4-stable.
--------------------------------------------------------------------------------


related_issues

relates,Closed,20513,Unloadable plugin convention breaks with Rails 4.2.3

Admin Redmine さんが3年以上前に更新

  • カテゴリPlugin API_20 にセット
  • 対象バージョン3.4.5_139 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0