Vote #79150
完了Too large avatar breaks gantt when assignee is a group
0%
説明
A 128px wide avatar icon breaks gantt view when the assignee of an issue is a group and "Use Gravatar user icons" setting is enabled.
!{width: 525px}.too-large-icon@2x.png!
The problem is introduced in Redmine 3.3.6 and 3.4.4 by #26699. The cause is that the HTML doesn't include "width" and "height" option because image_tag in Rails 4 doesn't accept an integer value for ":size" option (Rails 5 accepts both integer and string value, so the current trunk is not affected).
Redmine 3.4 (img element doesn't have "width" and "height" attributes):
The current trunk (img element has "width" and "height" attributes):
journals
--------------------------------------------------------------------------------
The behavior of image_tag has been changed by this commit:
"Allow to pass a string value to size option in `image_tag` and `video… · rails/rails@ab5f119":https://github.com/rails/rails/commit/ab5f119ac62cdbcc3c9d5c4fd36dafd187b038ca
--------------------------------------------------------------------------------
Patches for this issue.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Committed the fix to 3.4-stable and 3.3-stable branch.
Mischa, thank you for reviewing the patch.
--------------------------------------------------------------------------------
related_issues
relates,Closed,26699,Anonymous user should have their icon
relates,Closed,28208,Anonymous icon is wrongly displayed when assignee is a group