プロジェクト

全般

プロフィール

Vote #79152

完了

Test improvements for footnotes formatting syntax

Admin Redmine さんが約2年前に追加. 約2年前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
Text formatting_26
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
26
version_id:
99
issue_org_id:
28207
author_id:
1565
assigned_to_id:
332
comments:
3
status_id:
5
tracker_id:
3
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

This originates from #28119#note-2.

We might want to add a simple test (like "@ApplicationHelperTest#test_footnotes@":/projects/redmine/repository/revisions/17198/entry/trunk/test/helpers/application_helper_test.rb#L1051, but than in source:trunk/test/unit/lib/redmine/wiki_formatting/markdown_formatter_test.rb) for markdown footnotes as enabled per #16072.

And while looking at the above, the question of 'how many other textile syntax tests are there remaining, lurking outside of source:/trunk/test/unit/lib/redmine/wiki_formatting/textile_formatter_test.rb and what do we want to do with them?' came up...

** The answer to the first part would be 'several' (among them e.g. @ApplicationHelperTest#test_footnotes@). My answer to the second part of the question would be 'move them to the dedicated @TextileFormatterTest@ class'.

I'll leave two patches against source:/trunk@17198:

  • 0001-Add-footnotes-test-for-markdown-formatter-16072.patch ** This patch adds a footnotes test for the markdown formatter (@MarkdownFormatterTest#test_footnotes@).
  • 0002-Move-textile-footnotes-test-to-TextileFormatterTest.patch ** This patch moves @ApplicationHelperTest#test_footnotes@ to become @TextileFormatterTest#test_footnotes@.

In case there is consensus on my answer to the question raised under point 2, I'll open a dedicated container issue for it.

Note: I won't target this issue to any version, as I don't think this is of any use for the changelogs.


journals

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Committed. Thank you for improving the test suite.
--------------------------------------------------------------------------------


related_issues

relates,Closed,16072,Markdown footnote support

Admin Redmine さんが約2年前に更新

  • カテゴリText formatting_26 にセット
  • 対象バージョン4.0.0_99 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0