Vote #79196
未完了Commit messages referencing issues should stop at line breaks
0%
説明
When referencing an issue via commit message, the matching should stop at line breaks. Otherwise, unexpected things may happen.
E.g given the following commit message:
Initial version of Feature #123 Includes the following changes: #124 some UI fixes #125 still work in progress
the current implementation will mark @#125@ as fixed. I think, this is unexpected.
I've attached a patch, which replaces all @\s@ with @:blank:@ in the relevant regular expressions. Those matchers are equivalent, but @:blank:@ does not match @\r\n@. I've also added a test.
This bug was identified by Holger Just from Planio.
journals
--------------------------------------------------------------------------------
Thank you for detecting and fixing this issue, it looks good to me.
But I am afraid that some people make use of the current behavior, like the following example.
<pre>
Refs:
#1, #2, #3
</pre>
--------------------------------------------------------------------------------
Admin Redmine さんが約2年前に更新
- カテゴリ を SCM_3 にセット
- 対象バージョン を Candidate for next minor release_33 にセット