Vote #79220: Reject plugin same ID with registered one - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #79220

未完了

Reject plugin same ID with registered one

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

New

優先度:

通常

担当者:

カテゴリ:

Plugin API_20

対象バージョン:

Candidate for next major release_32

開始日:

2022/05/09

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/28412

category_id:

version_id:

issue_org_id:

28412

author_id:

284508

assigned_to_id:

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[New]

引用

説明

Redmine can register plugin same ID with registered one.
Currently, below problems exist.

@registered_plugins[id] is overwritten.
/admin/plugins shows only one plugin
but load_path, view_path, ... are changed

I want to reject and log warning second or later plugins.

functional/settings_controller_test.rb was already registered foo plugin twice. I cleared on teardown to pass unit test.

This ticket related to #27705.

journals

We see the following error when plugin IDs conflict. It is difficult to debug. I think the patch helps to find the cause of such problems.

<pre>
$ bundle exec rails c
/path/to/redmine/lib/redmine/menu_manager.rb:370:in `add_at': Child already added (RuntimeError)
from /path/to/redmine/lib/redmine/menu_manager.rb:387:in `add'
from /path/to/redmine/lib/redmine/menu_manager.rb:305:in `push'
...
</pre>
--------------------------------------------------------------------------------