Vote #79231
完了Syntax highlighter does not work if language name is single-quoted
0%
説明
Please see the screenshot below. Syntax highlighter does not work if "Text formatting" is set to "Textile" and the language name is enclosed by single quotation marks. The Textile formatter should accept single quotation marks as well as double quotation marks.
!{width: 252px; border: 1px solid #ccc;}.screenshot@2x.png!
journals
I think it is natural to use single quotes.
I wrote a patch to fix this defect.
--------------------------------------------------------------------------------
Mizuki ISHIKAWA wrote:
> I think it is natural to use single quotes.
> I wrote a patch to fix this defect.
I would recommend to add a tests for this single quotes case.
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> Mizuki ISHIKAWA wrote:
> > I think it is natural to use single quotes.
> > I wrote a patch to fix this defect.
>
> I would recommend to add a tests for this single quotes case.
I forgot to write a test.
I appreciate your advice.
This is the patch that added the test.
--------------------------------------------------------------------------------
LGTM. Setting target version to 3.3.8.
--------------------------------------------------------------------------------
Committed to the trunk and stable branches. Thank you for fixing this issue.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
duplicates,Closed,14443,Property class in <code> inside <pre> does not accept a single quotes