プロジェクト

全般

プロフィール

Vote #79344

完了

Redmine::VERSION::revision should take subversion_command setting into account

Admin Redmine さんが約4年前に追加. 約4年前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
Administration_8
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
8
version_id:
99
issue_org_id:
28920
author_id:
332
assigned_to_id:
332
comments:
5
status_id:
5
tracker_id:
1
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

The revision number may not be shown on admin_info page because the execution of the svn command fails in some cases.

Redmine::VERSION::revision method should take @scm_subversion_command@ setting into account.


Index: lib/redmine/version.rb
===================================================================
--- lib/redmine/version.rb  (revision 17354)
+++ lib/redmine/version.rb  (working copy)
@@ -17,7 +17,7 @@
       if File.directory?(File.join(Rails.root, '.svn'))
         begin
           path = Redmine::Scm::Adapters::AbstractAdapter.shell_quote(Rails.root.to_s)
-          if `svn info --xml #{path}` =~ /revision="(\d+)"/
+          if `#{Redmine::Scm::Adapters::SubversionAdapter.client_command} info --xml #{path}` =~ /revision="(\d+)"/
             return $1.to_i
           end
         rescue

journals

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Committed. The patch was provided by Yuichi Harada. Thank you for the contribution.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------


related_issues

relates,Closed,7517,Configurable path of executable for scm adapters
relates,Closed,32110,"already initialized constant Redmine::Scm::Adapters::SubversionAdapter::SVN_BIN" warning when executing rake tasks

Admin Redmine さんが約4年前に更新

  • カテゴリAdministration_8 にセット
  • 対象バージョン4.0.0_99 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0