プロジェクト

全般

プロフィール

Vote #79400

完了

Remove unused and broken method CustomField.visibility_condition

Admin Redmine さんが約4年前に追加. 約4年前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
Code cleanup/refactoring_30
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
30
version_id:
99
issue_org_id:
29160
author_id:
2784
assigned_to_id:
1
comments:
3
status_id:
5
tracker_id:
3
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

The class method was introduced in r12012 along with the instance method @CustomField#visibility_by_project_condition@. The method's body seems to follow the idea of the instance method but misses a lot of data required by it, including the @user@ and the @project_key@. As such, the method would always throw an exception when called.

Since the method is not tested, is never called by Redmine anywhere, and is unusable anyway, we can simply remove it as done by the attached patch.


journals

--------------------------------------------------------------------------------
I have confirmed the problem Holger reported. Setting target version to 4.0.0.
--------------------------------------------------------------------------------
Committed, thanks.
--------------------------------------------------------------------------------


related_issues

relates,Closed,5037,Role-based issue custom field visibility

Admin Redmine さんが約4年前に更新

  • カテゴリCode cleanup/refactoring_30 にセット
  • 対象バージョン4.0.0_99 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0