Vote #79411
完了Display custom fields on group pages
0%
説明
It's possible to add custom fields to groups, but they are no where displayed but in the edit view within the admin area.
The attached patch extends @groups#show@ to also list custom fields defined for the group. It's targeted at r17428.
journals
This is a screenshot of @/groups/:id@ page after applying the patch.
!{width: 355px; border: 1px #ccc solid}.screenshot-29189@2x.png!
--------------------------------------------------------------------------------
Thank you for posting the patch. I think this patch improves the consistency of UI.
But I wonder whether the heading "Attributes" is necessary. @/users/:id@ page does not add such a heading when showing custom fields (see http://www.redmine.org/users/347 for example). In addition, @:label_attribute_plural@ is only used in @app/views/auth_sources/_form_auth_source_ldap.html.erb@.
Do you think we can remove "@<h3><%= l(:label_attribute_plural) %></h3>@" from the patch?
--------------------------------------------------------------------------------
Thank you for reviewing this patch.
I don't have a strong opinion on this one. I've added the sub heading for cosmetic reasons. If you think it's not necessary, this is OK for me.
--------------------------------------------------------------------------------
I have slightly changed Gregor Schmidt's patch. Setting target version to 4.1.0.
--------------------------------------------------------------------------------
Go Maeda, lets have a basic test for this feature.
--------------------------------------------------------------------------------
I wrote a test for 20189.patch.
--------------------------------------------------------------------------------
Thank you very much for providing a test case.
--------------------------------------------------------------------------------
Committed the patch and test with a slight change. Thank you all for the contribution.
--------------------------------------------------------------------------------