Vote #79467: Pagination between repository entries and attachments of the same container - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #79467

完了

Pagination between repository entries and attachments of the same container

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

Attachments_19

対象バージョン:

4.0.0_99

開始日:

2022/05/09

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/29395

category_id:

version_id:

issue_org_id:

29395

author_id:

40856

assigned_to_id:

332

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

This feature was implemented for "Planio":https://plan.io/redmine-hosting and consists of 3 patches:

adds pagination under the attachment preview which allows to cycle through the list of attachments of the container object
adds pagination under the preview of repository entries to navigate other entries on the same level
adds some Javascript which binds left/right arrow keys to work like clicks on the previous / next links (only in the cases of 1 and 2).

journals

This is a screenshot after applying attachment:0001-attachments-prev-next-navigation.patch. I like this feature.

!{width: 484px; border: 1px solid #ccc;}.29395-pagination-screenshot@2x.png!
--------------------------------------------------------------------------------
+1

--------------------------------------------------------------------------------
I am adding a small improvement to this patch: When browsing through a series of attachments it's convenient for the user to have the pagniation always in the viewport in order to avoid scrolling after page change. The attached patch takes care, that the pagination is always visible.
--------------------------------------------------------------------------------
The pagination is really nice, but some features don't work on my environment. Could you look into it? The second problem is reproducible also on Planio.

# Left and right arrow keys don't work at all. Nothing occurs when I hit those keys.
# Bottom part of the content and pagination are not shown if I apply 0004-Let-pagination-always-be-visible.patch.

I tested with Firefox 62.0 and Chrome 69.0.3497.100 on macOS.
--------------------------------------------------------------------------------
The screenshot below describes the problem I wrote in #29395#note-4. The attachment '100-lines.txt' consists of 100 lines of text, but the page shows only 35 lines and a user cannot scroll down. No problem if 0004-Let-pagination-always-be-visible.patch is not applied.

!cannot-see-bottom-part-of-content.png!
--------------------------------------------------------------------------------
Thanks for reporting this problem. I will take care of it and update the patch.

--------------------------------------------------------------------------------
Here is an update to the patch, that should fix the before mentioned case.

Go MAEDA: could you delete the old version of the file @0004-Let-pagination-always-be-visible.patch@?

Thanks!
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Felix Gliesche wrote:
> Here is an update to the patch, that should fix the before mentioned case.

Thank you for updating the patch. But I could not find differences between before and after applying 0004-Let-pagination-always-be-visible.patch. Could you tell me how the patch should work? Please show me some screenshots if possible.

And, the left and right arrow key don't work on my environment (Firefox 62.0.2 and Chrome 69.0.3497.100 on macOS). Could you also investigate this?
--------------------------------------------------------------------------------
Go MAEDA wrote:
Could you tell me how the patch should work?

The new version of the patch is supposed to remove the height limiting for any plain text files, that is, the file should be shown as usual and the pagination below. So in turn the height limiting, keeping pagination visible at the bottom of the screen, should only be active for images / video where it makes the most sense. I just tried this out locally and it looked good to me.

> And, the left and right arrow key don't work on my environment (Firefox 62.0.2 and Chrome 69.0.3497.100 on macOS). Could you also investigate this?

The javascript function was indeed never called. I upload an updated version of the patch which also fixes the problem that pagination was triggered when modifier keys were pressed together with an arrow key (i.e. when trying to go back a page using Alt-ArrowLeft)

--------------------------------------------------------------------------------
Confirmed that everything is working fine now!
Setting target version to 4.1.0.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Committed the patch series. Thank you for providing the nice feature!
--------------------------------------------------------------------------------