Vote #79606
未完了Issue CSV export options: checkboxes have no effect for columns activated in query
0%
説明
The csv export option modal for issues has checkboxes for the description and last notes which are activated by default if these columns are activated for the current query. Disabling them manually has no effect: the columns are still exported to CSV because @query_as_hidden_field_tags@ adds them as hidden fields.
This adds an argument @ignored_column_names@ to @query_as_hidden_fields_tags@ which is used to ignore the description and last_notes columns for issues.
Patch works for Redmine 3.4 and 4.
journals
--------------------------------------------------------------------------------
Thank you for sharing the patch.
> The csv export option modal for issues has checkboxes for the description and last notes which are activated by default if these columns are activated for the current query. Disabling them manually has no effect: the columns are still exported to CSV because query_as_hidden_field_tags adds them as hidden fields.
I felt something wrong with this behavior.
I investigated a little to see if we can solve this problem by changing the view, but it seemed difficult.
I think the method proposed in attachment:0001-fix-Issue-CSV-export-options-checkboxes-have-no-effe.patch is valid.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
LGTM.
But is it ok to not update tests?
--------------------------------------------------------------------------------
If #33211 is implemented, this change will no longer be required.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
relates,New,33211,Include block columns (ex: Description, Last notes) in CSV export when option "All columns" is selected
Admin Redmine さんが約2年前に更新
- カテゴリ を Issues_2 にセット
- 対象バージョン を Candidate for next major release_32 にセット