Vote #79645
完了Add missing fixtures for test_create_should_send_notification
0%
説明
The bellow test fails when it is run in isolation
Failure: CommentTest#test_create_should_send_notification [/builds/marius-balteanu/redmine/test/unit/comment_test.rb:39]: "ActionMailer::Base.deliveries.size" didn't change by 2. Expected: 2 Actual: 1 bin/rails test test/unit/comment_test.rb:35
Attached a patch that adds the missing fixtures.
journals
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
And one more for test/functional/documents_controller_test.rb
<pre>
root@45ec3a6558b0:/work# ruby test/functional/documents_controller_test.rb
DEPRECATION WARNING: `secrets.secret_token` is deprecated in favor of `secret_key_base` and will be removed in Rails 6.0. (called from <top (required)> at /work/config/environment.rb:14)
Run options: --seed 39471
# Running:
...........F
Failure:
DocumentsControllerTest#test_create_with_one_attachment [test/functional/documents_controller_test.rb:135]:
Expected: 2
Actual: 1
bin/rails test test/functional/documents_controller_test.rb:109
...
Finished in 1.231643s, 12.1788 runs/s, 34.9127 assertions/s.
15 runs, 43 assertions, 1 failures, 0 errors, 0 skips
</pre>
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> And one more for test/functional/documents_controller_test.rb
>
> [...]
I have created another issue #30054.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Committed. Thank you for your daily contribution.
--------------------------------------------------------------------------------
related_issues
copied_to,Closed,30054,Add missing fixtures for test_create_with_one_attachment
Admin Redmine さんが4年以上前に更新
- カテゴリ を Code cleanup/refactoring_30 にセット
- 対象バージョン を 4.0.0_99 にセット