プロジェクト

全般

プロフィール

Vote #79687

完了

Add missing fixture for reports_controller_test

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
Code cleanup/refactoring_30
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
30
version_id:
99
issue_org_id:
30120
author_id:
107353
assigned_to_id:
332
comments:
2
status_id:
5
tracker_id:
1
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

Running test/functional/reports_controller_test.rb in isolation will fail because of a missing fixtures. I've detected the issue here: https://gitlab.com/marius-balteanu/redmine/-/jobs/130977733


root@45ec3a6558b0:/work# ruby test/functional/reports_controller_test.rb 
DEPRECATION WARNING: `secrets.secret_token` is deprecated in favor of `secret_key_base` and will be removed in Rails 6.0. (called from  at /work/config/environment.rb:14)
Run options: --seed 6130

# Running:

...F

Failure:
ReportsControllerTest#test_issue_report_without_subprojects_issues [test/functional/reports_controller_test.rb:61]:
Expected at least 1 element matching "table.list tbody :nth-child(1):first", found 0..
Expected 0 to be >= 1.


bin/rails test test/functional/reports_controller_test.rb:53

F

Failure:
ReportsControllerTest#test_issue_report_with_subprojects_issues [test/functional/reports_controller_test.rb:45]:
Expected at least 1 element matching "table.list tbody :nth-child(1):first", found 0..
Expected 0 to be >= 1.


bin/rails test test/functional/reports_controller_test.rb:37

F

Failure:
ReportsControllerTest#test_get_issue_report_details_by_tracker_without_subprojects_issues [test/functional/reports_controller_test.rb:138]:
Expected at least 1 element matching "table.list tbody :nth-child(1)", found 0..
Expected 0 to be >= 1.


bin/rails test test/functional/reports_controller_test.rb:129

F

Failure:
ReportsControllerTest#test_get_issue_report_details_by_tracker_should_show_issue_count [test/functional/reports_controller_test.rb:163]:
Expected at least 1 element matching "table.list tbody :nth-child(1)", found 0..
Expected 0 to be >= 1.


bin/rails test test/functional/reports_controller_test.rb:152

F

Failure:
ReportsControllerTest#test_get_issue_report_details_by_tracker_with_subprojects_issues [test/functional/reports_controller_test.rb:115]:
Expected at least 1 element matching "table.list tbody :nth-child(1)", found 0..
Expected 0 to be >= 1.


bin/rails test test/functional/reports_controller_test.rb:106

The fix:


diff --git a/test/functional/reports_controller_test.rb b/test/functional/reports_controller_test.rb
index 0b922f288..c1b60bcdd 100644
--- a/test/functional/reports_controller_test.rb
+++ b/test/functional/reports_controller_test.rb
@@ -25,7 +25,8 @@ class ReportsControllerTest < Redmine::ControllerTest
            :member_roles,
            :members,
            :enabled_modules,
-           :versions
+           :versions,
+           :workflows
 
   def test_get_issue_report
     get :issue_report, :params => {

journals

--------------------------------------------------------------------------------
Committed. Thanks.
--------------------------------------------------------------------------------

Admin Redmine さんが3年以上前に更新

  • カテゴリCode cleanup/refactoring_30 にセット
  • 対象バージョン4.0.0_99 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0