プロジェクト

全般

プロフィール

Vote #79742

完了

test_links_separated_with_line_break_should_link tests nothing

Admin Redmine さんが約4年前に追加. 約4年前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
Code cleanup/refactoring_30
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
30
version_id:
127
issue_org_id:
30347
author_id:
362529
assigned_to_id:
332
comments:
2
status_id:
5
tracker_id:
3
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

Since Redmine::WikiFormattingTest#test_links_separated_with_line_break_should_link ( source:trunk/test/unit/lib/redmine/wiki_formatting_test.rb#L57 ) does not have an assert method, the test is not executed.

$ bundle exec rake test TEST=test/unit/lib/redmine/wiki_formatting_test.rb:57
Run options: --seed 9224

# Running:

.

Finished in 0.023977s, 41.7066 runs/s, 0.0000 assertions/s.
1 runs, 0 assertions, 0 failures, 0 errors, 0 skips
$

I made a patch, and attach it.


diff --git a/test/unit/lib/redmine/wiki_formatting_test.rb b/test/unit/lib/redmine/wiki_formatting_test.rb
index b460bad35..6f05d3ef9 100644
--- a/test/unit/lib/redmine/wiki_formatting_test.rb
+++ b/test/unit/lib/redmine/wiki_formatting_test.rb
@@ -64,14 +64,15 @@ DIFF
 

link: https://www.redmine.org
http://www.redmine.org

EXPECTED - + + assert_equal expected.gsub(%r{[\r\n\t]}, ''), Redmine::WikiFormatting::NullFormatter::Formatter.new(raw).to_html.gsub(%r{[\r\n\t]}, '') end def test_supports_section_edit with_settings :text_formatting => 'textile' do assert_equal true, Redmine::WikiFormatting.supports_section_edit? end - + with_settings :text_formatting => '' do assert_equal false, Redmine::WikiFormatting.supports_section_edit? end

journals

LGTM. Setting the target version to 4.1.0.
--------------------------------------------------------------------------------
Committed. Thanks.
--------------------------------------------------------------------------------

Admin Redmine さんが約4年前に更新

  • カテゴリCode cleanup/refactoring_30 にセット
  • 対象バージョン4.1.0_127 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0