Vote #79745
完了Drop Ruby 2.2 support
0%
説明
Currently, Redmine 4.0 supports Ruby 2.2. But the latest nokogiri gem 1.10.0 supports 2.3 and later, does not 2.2. So, we cannot update nogogiri gem to 1.10.0 as long as Redmine officially supports Ruby 2.2.
However, it is necessary to update nokogiri to 1.10.0 in order to support Ruby 2.6 because older nokogiri does not support Ruby 2.6 on Windows (https://github.com/sparklemotion/nokogiri/pull/1850).
We have to choose the Ruby version we support, 2.2 or 2.6. Needless to say, Redmine 4.0 should support Ruby 2.6 rather than retired 2.2.
journals
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
What about just locking nokogiri 1.9.0 for Ruby 2.2?
--------------------------------------------------------------------------------
Pavel Rosický wrote:
> What about just locking nokogiri 1.9.0 for Ruby 2.2?
You are right. I quite forgot about it. This should work.
<pre><code class="diff">
Index: Gemfile
===================================================================
--- Gemfile (revision 17777)
+++ Gemfile (working copy)
@@ -14,7 +14,7 @@
gem "mail", "~> 2.7.1"
gem "csv", "~> 3.0.1" if RUBY_VERSION >= "2.3" && RUBY_VERSION < "2.6"
-gem "nokogiri", "~> 1.9.0"
+gem "nokogiri", (RUBY_VERSION >= "2.3" ? "~> 1.10.0" : "~> 1.9.1")
gem "i18n", "~> 0.7.0"
# Windows does not include zoneinfo files, so bundle the tzinfo-data gem
</code></pre>
--------------------------------------------------------------------------------
In my opinion, we should drop Ruby 2.2 support in version:"4.1.0".
--------------------------------------------------------------------------------
Jean-Philippe Lang is considering to drop Ruby 2.2 support in 4.0-stable (see #30161#note-3). I will leave this issue to him.
--------------------------------------------------------------------------------
Go MAEDA wrote:
> Jean-Philippe Lang is considering to drop Ruby 2.2 support in 4.0-stable (see #30161#note-3). I will leave this issue to him.
Agree.
I proposed version:"4.1.0" because version:"4.0.1" will be a maintenance release (mostly with bug fixes and small changes) and dropping support for Ruby 2.2 could have an important impact:
* Server administrators will need to update the Ruby version on installations with Ruby 2.2.
* The codebase of the plugins compatible with 4.0 must be rechecked by their developers to support 4.0.1.
Discussions on the same topic: #25538
--------------------------------------------------------------------------------
We don't have to drop Ruby 2.2 support in a hurry for now. And I think there isn't any harm to commit the patch #30356#note-4 to the trunk and 4.0-stable.
I would like to commit #30356#note-4 as a part of #30241. What do you all think?
--------------------------------------------------------------------------------
Go MAEDA wrote:
> We don't have to drop Ruby 2.2 support in a hurry for now. And I think there isn't any harm to commit the patch #30356#note-4 to the trunk and 4.0-stable.
>
> I would like to commit #30356#note-4 as a part of #30241. What do you all think?
I’m totally agree.
--------------------------------------------------------------------------------
Uses Nokogiri 1.9 for Ruby 2.2, 1.10 for Ruby >=2.3. We don't have to drop support for Ruby 2.2. See r17778.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
I'm reopening this for version:"4.1.0".
--------------------------------------------------------------------------------
The attached patch removes code for Ruby 2.2.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Committed. Redmine 4.1 supports Ruby 2.3 and later.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
relates,Closed,30241,Update nokogiri gem (~> 1.10.0)
blocks,Closed,29946,Update i18n gem (~> 1.6.0)