Vote #79760
完了Table rows are not highlighted on mouseover on some pages
0%
説明
I am testing redmine v4.0.0 and discovered that hovering on some pages does not work.
Till now I discovered that problem on:
- .../projects/ProjectName/settings/activities
- .../admin/projects
- .../users
- .../groups
- .../roles
- .../trackers and so on....
With hovering I mean: when mouse pointer is over some row on table, whole row is highlited (yellow like in version e.g 2.3).
Without hovering, it is realy difficult to not to make mistake while selecting action on far right on that row, while row label is on the far left.
journals
Confirmed the problem in 3.4.7 and 4.0.0. No problem was found in 3.3.9.
--------------------------------------------------------------------------------
The fix is quite simple:
<pre><code class="diff">
diff --git a/public/stylesheets/application.css b/public/stylesheets/application.css
index fa59d6a..80defce 100644
--- a/public/stylesheets/application.css
+++ b/public/stylesheets/application.css
@@ -352,13 +352,13 @@ tr.group a.toggle-all { color: #aaa; font-size: 80%; display:none; float:right;
tr.group:hover a.toggle-all { display:inline;}
a.toggle-all:hover {text-decoration:none;}
-table.list tbody tr:hover { background-color:#ffffdd; }
-table.list tbody tr.group:hover { background-color:inherit; }
table td {padding:2px;}
table p {margin:0;}
table.list:not(.odd-even) tbody tr:nth-child(odd), .odd, #issue-changesets div.changeset:nth-child(odd) { background-color:#f6f7f8; }
table.list:not(.odd-even) tbody tr:nth-child(even), .even, #issue-changesets div.changeset:nth-child(even) { background-color: #fff; }
+table.list tbody tr:hover { background-color:#ffffdd !important; }
+table.list tbody tr.group:hover { background-color:inherit !important; }
tr.builtin td.name {font-style:italic;}
</code></pre>
Even if I'm not a fan of "!important", I think that in this case it is ok to use it.
--------------------------------------------------------------------------------
Is same fix applicable to v4.0.0? If not, can you provide fixed file (I assume it is only application.css), to upload to v4.0.0 redmine installation?
--------------------------------------------------------------------------------
VD DV wrote:
> Is same fix applicable to v4.0.0? If not, can you provide fixed file (I assume it is only application.css), to upload to v4.0.0 redmine installation?
Yes, it is.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Committed the patch. Thank you all for reporting and fixing this issue.
VD DV wrote:
> Is same fix applicable to v4.0.0? If not, can you provide fixed file (I assume it is only application.css), to upload to v4.0.0 redmine installation?
Please replace application.css with https://www.redmine.org/projects/redmine/repository/revisions/17801/raw/branches/4.0-stable/public/stylesheets/application.css.
--------------------------------------------------------------------------------
The change r17800 caused undesirable behavior in the issues list. Multiple selected issues are also highlighted on mouseover, so you can not read the text.
I will revert the change.
!{width: 432px; border: 1px solid #ccc;}.undesirable-highlighting-in-issues-list@2x.png!
--------------------------------------------------------------------------------
Go MAEDA wrote:
> The change r17800 caused undesirable behavior in the issues list. Multiple selected issues are also highlighted on mouseover, so you can not read the text.
>
> I will revert the change.
>
> !{width: 432px; border: 1px solid #ccc;}.undesirable-highlighting-in-issues-list@2x.png!
Sorry, I’ll rewrite the fix.
--------------------------------------------------------------------------------
Attached a better fix. I've checked both scenarios and it works well.
Sorry for my previous fix and a note to myself: "!important is never safe"
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> Attached a better fix. I've checked both scenarios and it works well.
Committed. Thanks!
> a note to myself: "!important is never safe"
I must not forget this, too.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------