Vote #79763
完了Useless "Delete issues" tracker permission is shown on the role page for Anonymous and Non-member
0%
説明
Since you cannot grant a "Delete issues" permission for Anonymous and Non-member roles, "Delete issues" column in the tracker permission table on the role page is useless. The column should be hidden like default "Reporter" role.
!{width: 773px; border: 1px solid #ccc;}.delete-issues-tracker-permission@2x.png!
journals
It was displayed "Delete issues" column in the tracker permission table on the role page because it was not confirmed the settable permissions of the role.
I attached a patch.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
LGTM but I propose a slight change as follows. Using @&@ operator is simpler and much faster than using @delete_if@.
<pre><code class="erb">
<% permissions = [:view_issues, :add_issues, :edit_issues, :add_issue_notes, :delete_issues] & setable_permissions.collect(&:name) %>
</code></pre>
Setting the target version to 4.1.0.
--------------------------------------------------------------------------------
Committed the patch. Thank you for fixing this issue.
--------------------------------------------------------------------------------