Vote #79772
完了Remove unnecessary bgl and bgr wrappers from the footer
0%
説明
There is a footer container, which has 2 more containers inside named bgl and bgr, considering that footer has nothing in it, but a short line of text, and I don't think we will ever need anything else from the footer, than just displaying this line, I think they both should be killed and text that's contained by it to be instead wrapped directly by a #footer div.
journals
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
wrapper2, .bgl, and .bgr were added in response to the request #871. Those classes are no longer used in both the default theme and redmine.org's theme.
--------------------------------------------------------------------------------
LGTM.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
The classes are no longer used even in redmine.org. Setting the target version to 4.1.0.
--------------------------------------------------------------------------------
Committed the patch. Thank you for your contribution.
--------------------------------------------------------------------------------
I think that this change will, without further action, become problematic for the redmine.org instance:
_<screenshot removed>_
--------------------------------------------------------------------------------
Please ignore my previous comment. I misinterpreted some things.
--------------------------------------------------------------------------------
related_issues
relates,Closed,30231,Operation: "Unwraping The Mine" or conerns about how elements are wrapped
relates,Closed,871,Commit new CSS styles!
Admin Redmine さんが約4年前に更新
- カテゴリ を Code cleanup/refactoring_30 にセット
- 対象バージョン を 4.1.0_127 にセット