Vote #79785
完了Footer is not placed at the bottom on pages with little content
0%
説明
I'm opening this as a placeholder for now to upload the patch later.
If the decision to remove wrappers will be accepted in #30448, then there will need to be changes to the #main, else if all the wrappers will stay, then there will need to be the changes to the #wrapper.
#footer is however going to receive same rules for both approaches. :)
journals
What is the purpose of making the footer sticky? I don't see anything in the footer that needs to be always visible.
--------------------------------------------------------------------------------
Jean-Philippe, apologies for vague description, what I mean by setting footer sticky, is for it to stick to the bottom of the page, while always expanding the #main block (or a wrapper) in 100% of available vertical height, unless the page's content needs more space.
I think it would be better than having footer ending up in the middle of the screen on pages where there is little or no content.
For reference please see the *concept-gridbox-version.html* file in the #30451#note-6 and click "Insert Lorem ipsum" button multiple times while observing the footer to see what I propose :)
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Here is a patch for the base layout to fill the visible space entirely. The footer always sticks to the bottom until the page is bigger than the visible height. It's quite pleasing for my eyes. The footer doesn't jump anymore when changing views.
**Original login view**
!{border: 1px solid #ccc; width: 600px;}.original_login_screen.png!
**With the patch applied**
!{border: 1px solid #ccc; width: 600px;}.patched_login_screen.png!
--------------------------------------------------------------------------------
Bernhard, I've tested your patch in several browsers (including IE 11 and Edge) and it works very well, nice job.
I would love to see this fixed in version:"4.1.0" along with #30435. It's very annoying to see the footer and the sidebar ended at 600px when there is not too much content in the page.
--------------------------------------------------------------------------------
I had a chat with Go and it's OK for him, so LGTM! :-)
--------------------------------------------------------------------------------
Committed the patch. Thank you for your contribution.
--------------------------------------------------------------------------------
I think it's safer to target the wrapper elements by their id instead of using "starting with":
<pre><code class="diff">
Mariuss-MacBook-Pro:redmine mariusbalteanu$ git diff
diff --git a/public/stylesheets/application.css b/public/stylesheets/application.css
index d5f1762e3..00ca660f0 100644
--- a/public/stylesheets/application.css
+++ b/public/stylesheets/application.css
@@ -11,7 +11,7 @@ h4 {border-bottom: 1px solid #ccc; font-weight:normal;}
pre, code {font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace;}
/***** Layout *****/
-div[id^="wrapper"] { min-height: inherit; }
+div#wrapper, div#wrapper2, div#wrapper3 { min-height: inherit; }
#wrapper {background: white;overflow: hidden;}
#wrapper3 { display: flex; flex-direction: column; }
</code></pre>
@Bernhard, do you see any problem with this change?
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> I think it's safer to target the wrapper elements by their id instead of using "starting with":
>
> [...]
>
> @Bernhard, do you see any problem with this change?
No, you're right. wrapper is quite generic and could be used in more places.
I think it should be changed this way.
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> I think it's safer to target the wrapper elements by their id instead of using "starting with":
>
> [...]
>
> @Bernhard, do you see any problem with this change?
Committed the fix in r18446. Thanks.
--------------------------------------------------------------------------------